New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RL non-generic fixed window, sliding window implementations #68087

Merged

BrennanConroy merged 12 commits into dotnet:main from shreyaverma165:shreyaverma/nongenericAPI

Apr 28, 2022

Contributor

shreyaverma165 commented Apr 15, 2022

Fixes: dotnet/aspnetcore#37381

** Updating this PR with comments and test cases.

shreyaverma165 added the area-System.Threading label

shreyaverma165 added this to the 7.0.0 milestone

shreyaverma165 requested review from halter73 and BrennanConroy

April 15, 2022 20:26

ghost assigned shreyaverma165

dotnet-issue-labeler bot added the new-api-needs-documentation label

dotnet-issue-labeler bot commented Apr 15, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost commented Apr 15, 2022

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes: dotnet/aspnetcore#37381

** Updating this PR with comments and test cases.

Author:	shreyaverma165
Assignees:	-
Labels:	`area-System.Threading`
Milestone:	7.0.0

dnfadmin commented Apr 15, 2022 •

edited

Loading

All CLA requirements met.

shreyaverma165 force-pushed the shreyaverma/nongenericAPI branch 3 times, most recently from f20f4a9 to 8ad696c Compare

April 15, 2022 20:43

BrennanConroy reviewed

View reviewed changes

.../System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs Outdated Show resolved Hide resolved

.../System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs Outdated Show resolved Hide resolved

.../System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs Outdated Show resolved Hide resolved

.../System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs Outdated Show resolved Hide resolved

.../System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs Show resolved Hide resolved

.../System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs Outdated Show resolved Hide resolved

.../System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs Show resolved Hide resolved

.../System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs Show resolved Hide resolved

...em.Threading.RateLimiting/src/System/Threading/RateLimiting/FixedWindowRateLimiterOptions.cs Outdated Show resolved Hide resolved

shreyaverma165 force-pushed the shreyaverma/nongenericAPI branch 3 times, most recently from 5add2b3 to 601f6fd Compare

April 19, 2022 00:11

shreyaverma165 marked this pull request as ready for review

April 19, 2022 00:12

shreyaverma165 requested a review from BrennanConroy

April 19, 2022 00:13

BrennanConroy reviewed

View reviewed changes

...em.Threading.RateLimiting/src/System/Threading/RateLimiting/FixedWindowRateLimiterOptions.cs Outdated Show resolved Hide resolved

...em.Threading.RateLimiting/src/System/Threading/RateLimiting/FixedWindowRateLimiterOptions.cs Outdated Show resolved Hide resolved

...es/System.Threading.RateLimiting/src/System/Threading/RateLimiting/FixedWindowRateLimiter.cs Outdated Show resolved Hide resolved

...es/System.Threading.RateLimiting/src/System/Threading/RateLimiting/FixedWindowRateLimiter.cs Outdated Show resolved Hide resolved

....Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiterOptions.cs Outdated Show resolved Hide resolved

.../System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs Outdated Show resolved Hide resolved

.../System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs Outdated Show resolved Hide resolved

.../System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs Outdated Show resolved Hide resolved

.../System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs Outdated Show resolved Hide resolved

.../System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs Outdated Show resolved Hide resolved

shreyaverma165 force-pushed the shreyaverma/nongenericAPI branch from 953b529 to 6c3f70a Compare

April 19, 2022 03:02

Member

BrennanConroy commented Apr 19, 2022

I think the ref file needs to be updated. dotnet msbuild /t:GenerateReferenceAssemblySource

shreyaverma165 requested a review from BrennanConroy

April 19, 2022 04:34

BrennanConroy reviewed

View reviewed changes

src/libraries/Microsoft.Bcl.AsyncInterfaces/ref/Microsoft.Bcl.AsyncInterfaces.cs Outdated Show resolved Hide resolved

src/libraries/System.Threading.RateLimiting/ref/System.Threading.RateLimiting.cs Outdated Show resolved Hide resolved

.../System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs Outdated Show resolved Hide resolved

src/libraries/System.Threading.RateLimiting/tests/SlidingWindowRateLimiterTests.cs Show resolved Hide resolved

shreyaverma165 marked this pull request as draft

April 19, 2022 17:08

shreyaverma165 force-pushed the shreyaverma/nongenericAPI branch 4 times, most recently from 4cb332f to e825bd1 Compare

April 25, 2022 08:47

shreyaverma165 marked this pull request as ready for review

April 25, 2022 08:48

shreyaverma165 requested a review from BrennanConroy

April 25, 2022 08:48

shreyaverma165 marked this pull request as ready for review

April 25, 2022 23:54

shreyaverma165 requested a review from BrennanConroy

April 25, 2022 23:54

BrennanConroy reviewed

View reviewed changes

.../System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs Show resolved Hide resolved

shreyaverma165 force-pushed the shreyaverma/nongenericAPI branch from 218b8dc to d368ecd Compare

April 26, 2022 18:58

shreyaverma165 requested a review from BrennanConroy

April 26, 2022 19:53

shreyaverma165 force-pushed the shreyaverma/nongenericAPI branch from 049e500 to a1f8d68 Compare

April 26, 2022 21:54

BrennanConroy reviewed

View reviewed changes

.../System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs Outdated Show resolved Hide resolved

src/libraries/System.Threading.RateLimiting/tests/SlidingWindowRateLimiterTests.cs Outdated Show resolved Hide resolved

src/libraries/System.Threading.RateLimiting/tests/SlidingWindowRateLimiterTests.cs Outdated Show resolved Hide resolved

.../System.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs Outdated Show resolved Hide resolved

shreyaverma165 force-pushed the shreyaverma/nongenericAPI branch from a1f8d68 to 12de257 Compare

April 27, 2022 19:32

shreyaverma165 requested a review from BrennanConroy

April 27, 2022 20:08

BrennanConroy approved these changes

View reviewed changes

shreyaverma165 force-pushed the shreyaverma/nongenericAPI branch from 12de257 to 743ca69 Compare

April 27, 2022 22:25

shreyaverma165 added 12 commits

April 28, 2022 12:23


          Add RL non-generic fixed window, sliding window implementations

5c8840c


          Add updates to the sliding window GetAvailablePermits

ee146d5


          Revert changes made to BclInterfaces/ref file

62dc02c


          Update ref/System.Threading.RateLimiting

43b5e03


          import Tasks namespace

1535b57


          Update tests anf fix up test failures caused by window segments

7c89e54


          Add fixes to sliding window rate limiting tests


          Update sliding window tests to use a window size greater than 1

5c00494


          Update how oldSegmentRequestCount is calculated

64b9c2e


          Add test to verify multiple acquires

60302a3


          Adding comments

7ac2e15


          Add the failed queued requests back to available permits

5a10be2

shreyaverma165 force-pushed the shreyaverma/nongenericAPI branch from 743ca69 to 5a10be2 Compare

April 28, 2022 19:24

BrennanConroy merged commit 1d7c119 into dotnet:main

BrennanConroy mentioned this pull request

Finish implementations for non-generic rate limiters (Fixed windows, Sliding windows, Token bucket, Concurrency limiter) dotnet/aspnetcore#37381

Closed

4 tasks

BrennanConroy pushed a commit to BrennanConroy/runtime that referenced this pull request


          Add RL non-generic fixed window, sliding window implementations (dotn…

d649022

…et#68087)

BrennanConroy mentioned this pull request

Add Fixed and Sliding Window RateLimiters + PartitionedRateLimiter.Create #68695

Merged

mmitche pushed a commit that referenced this pull request


          Add Fixed and Sliding Window RateLimiters + PartitionedRateLimiter.Cr…

9c37a3b

…eate (#68695)

* Add RL non-generic fixed window, sliding window implementations (#68087)

* Add initial impl of PartitionedRateLimiter.Create (#67677)

Co-authored-by: Shreya Verma <[email protected]>

ghost locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Threading new-api-needs-documentation