Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTTP/3] Reenable ResponseCancellation_ServerReceivesCancellation #67535

Merged
merged 1 commit into from
Apr 12, 2022
Merged

[HTTP/3] Reenable ResponseCancellation_ServerReceivesCancellation #67535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Http3.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,6 @@ public enum CancellationType
}

[ConditionalTheory(nameof(IsMsQuicSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/56194")]
[InlineData(CancellationType.Dispose)]
[InlineData(CancellationType.CancellationToken)]
public async Task ResponseCancellation_ServerReceivesCancellation(CancellationType type)
Expand All @@ -701,7 +700,7 @@ public async Task ResponseCancellation_ServerReceivesCancellation(CancellationTy

HttpRequestData request = await stream.ReadRequestDataAsync().ConfigureAwait(false);

int contentLength = 2*1024*1024;
int contentLength = 2 * 1024 * 1024;
var headers = new List<HttpHeaderData>();
headers.Append(new HttpHeaderData("Content-Length", contentLength.ToString(CultureInfo.InvariantCulture)));

Expand All @@ -715,7 +714,7 @@ public async Task ResponseCancellation_ServerReceivesCancellation(CancellationTy
// We are asserting that PEER_RECEIVE_ABORTED would still arrive eventually

var ex = await Assert.ThrowsAsync<QuicStreamAbortedException>(() => SendDataForever(stream).WaitAsync(TimeSpan.FromSeconds(10)));
Assert.Equal((type == CancellationType.CancellationToken ? 268 : 0xffffffff), ex.ErrorCode);
Assert.Equal(268, ex.ErrorCode);

serverDone.Release();
});
Expand Down