Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invalid assertion in InitializePropCache #67482

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Remove invalid assertion in InitializePropCache #67482

merged 1 commit into from
Apr 2, 2022

Conversation

eiriktsarpalis
Copy link
Member

Contributes to #60962.

@ghost ghost assigned eiriktsarpalis Apr 2, 2022
@ghost
Copy link

ghost commented Apr 2, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #60962.

Author: eiriktsarpalis
Assignees: eiriktsarpalis
Labels:

area-System.Text.Json
Milestone: -

@eiriktsarpalis eiriktsarpalis added this to the 7.0.0 milestone Apr 2, 2022
krwq
krwq requested changes Apr 2, 2022
View reviewed changes
Copy link
Member

@krwq krwq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not edit this code path. I'll be changing this code path in my next change and this will create unnecessary merge conflict for me. Also the assert will actually be true after my changes

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Apr 2, 2022
@jkotas
Copy link
Member

jkotas commented Apr 2, 2022 •
edited
Loading

Please do not edit this code path. I'll be changing this code path in my next change and this will create unnecessary merge conflict for me. Also the assert will actually be true after my changes

@krwq This is causing CI instability. Unless you plan to have your changes merged in less than a day, I would like to see something to be done about this quickly.

krwq
krwq approved these changes Apr 2, 2022
View reviewed changes
Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving so that CI is greener

@krwq
Copy link
Member

krwq commented Apr 2, 2022

quic failures are unrelated so merging

@krwq krwq merged commit f302170 into dotnet:main Apr 2, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krwq krwq krwq approved these changes

@stephentoub stephentoub Awaiting requested review from stephentoub

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Text.Json needs-author-action An issue or pull request that requires more info or actions from the author.
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@eiriktsarpalis @jkotas @krwq