Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing side effect flags on HWI nodes #67206

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Fix missing side effect flags on HWI nodes #67206

merged 3 commits into from
Mar 31, 2022

Conversation

SingleAccretion
Copy link
Contributor

We are not expecting diffs.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 27, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 27, 2022
@ghost
Copy link

ghost commented Mar 27, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

We are not expecting diffs.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@SingleAccretion
Copy link
Contributor Author

SingleAccretion commented Mar 28, 2022 •
edited
Loading

CI failures are:

  1. Windows ARM64: JIT.HardwareIntrinsics tests failed with "almost" empty logs #67233.
  2. Mono OSX x64: Test failure DllImportGenerator.UnitTests.IncrementalGenerationTests.ChangingMarshallingStrategy_RegeneratesStub #61643.

No diffs.
@dotnet/jit-contrib

This change now also contains a Mono interpreter fix to null check the source of an LDOBJ, cc @BrzVlad.

@SingleAccretion SingleAccretion marked this pull request as ready for review March 28, 2022 18:54
BruceForstall
BruceForstall approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RyuJIT + test changes LGTM. I can't merge until someone reviews the Mono interpreter change.

BrzVlad
BrzVlad approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@BrzVlad BrzVlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mono interpreter changes are good

@BruceForstall BruceForstall merged commit c499045 into dotnet:main Mar 31, 2022
@SingleAccretion SingleAccretion deleted the HWI-Side-Effect-Fixes branch March 31, 2022 21:11
@JulieLeeMSFT JulieLeeMSFT mentioned this pull request Apr 29, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

@tannergooding tannergooding tannergooding approved these changes

@BrzVlad BrzVlad BrzVlad approved these changes

@vargaz vargaz Awaiting requested review from vargaz

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SingleAccretion @BrzVlad @tannergooding @BruceForstall