Reflection.Emit cleanups #67170
Merged
Reflection.Emit cleanups #67170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-reflection Issue DetailsSee commit descriptions for details
|
This check is trying to ensure that the Types passed in are somewhat well-behaving by verifying that Module and Assembly properties are non-null. This validation is not done consistently and it has very value. There are many other ways custom types can misbehave. Also, this saves allocations of the object[] arrays for the params argument.
Simplify Exception.Source to avoid Reflection.Emit dependencies in Exception implementation
marek-safar
reviewed
Mar 26, 2022
|
The mono changes look ok to me. |
steveharter
approved these changes
Apr 19, 2022
src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/AssemblyBuilder.cs
Show resolved
Hide resolved
directhex
pushed a commit
to directhex/runtime
that referenced
this pull request
Apr 21, 2022
* Delete AssemblyBuilder.CheckContext checks This check is trying to ensure that the Types passed in are somewhat well-behaving by verifying that Module and Assembly properties are non-null. This validation is not done consistently and it has very value. There are many other ways custom types can misbehave. Also, this saves allocations of the object[] arrays for the params argument. * Simplify Exception.Source Simplify Exception.Source to avoid Reflection.Emit dependencies in Exception implementation * Delete unnecessary clone of CustomAttributeBuilder enumeration * Factor out simple ModuleBuilder and TypeBuilder forwardering methods * Delete ComVisible annotations in Mono * Delete redundant FCall
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit descriptions for details