Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entry point for EnumPrinters #67081

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Conversation

elinor-fung
Copy link
Member

Fixes #66186

@ghost
Copy link

ghost commented Mar 24, 2022

Tagging subscribers to this area: @dotnet/area-system-drawing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #66186

Author: elinor-fung
Assignees: -
Labels:

area-System.Drawing

Milestone: -

@danmoseley danmoseley merged commit c49593c into dotnet:main Mar 24, 2022
@danmoseley
Copy link
Member

This is because the generator code does not probe W and A?

@elinor-fung elinor-fung deleted the fixEnumPrinters branch March 24, 2022 17:39
@elinor-fung
Copy link
Member Author

Yeah, the generator always uses ExactSpelling=true for the inner blittable p/invoke it generates, so A/W suffixes won't be probed - part of our 'remove Windows-isms and make everything explicit' desire.

radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An exception is thrown when getting PrinterSettings.InstalledPrinters
4 participants