Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent BaseType from returning default #66955

Merged
merged 1 commit into from
Mar 22, 2022
Merged

prevent BaseType from returning default #66955

merged 1 commit into from
Mar 22, 2022

Conversation

pedrobsaila
Copy link
Contributor

Fixes #66810

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 21, 2022
This was referenced Mar 21, 2022
Closed
Closed
MichalStrehovsky
MichalStrehovsky approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MichalStrehovsky MichalStrehovsky merged commit 7a01e0f into dotnet:main Mar 22, 2022
@pedrobsaila pedrobsaila deleted the 66810 branch March 22, 2022 08:22
@josephmoresena
Copy link
Contributor

Thanks! Now Type.IsSubclassOf(Type) works in reflection-free-mode.

radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
@pedrobsaila @radekdoulik
prevent BaseType from returning default (dotnet#66955)
fcb382f
@ghost ghost locked as resolved and limited conversation to collaborators Apr 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

Assignees
No one assigned
Labels
area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NativeAOT: Type.BaseType throws exeption when there is no basetype in reflection-free-mode
3 participants
@pedrobsaila @josephmoresena @MichalStrehovsky