Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double the size of the previous segment #66930

Closed
wants to merge 4 commits into from
Closed

Commits on Mar 21, 2022

  1. Double the size of each segment

    - This change comes after long observations around how pipelines doesn't work well for copying large blocks of data mainly due to the segment allocation strategy. Today we allocate each segment > minimum segment size < max pool size. This works well if data is being quickly consumed because we can keep memory allocations to a minimum but doesn't work well when there's large chunks of data are being written. This change doubles the segment size based on the previous segment up to 1MB (arbitrary limit). This should make the default behavior work pretty much the same as today but performance of larger writes/reads should improve.
    davidfowl committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    01110fa View commit details
    Browse the repository at this point in the history
  2. Fixed tests and comment

    davidfowl committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    21ee822 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2022

  1. Make GetSegmentSize static

    davidfowl committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    d4f728c View commit details
    Browse the repository at this point in the history
  2. Again

    davidfowl committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    9385601 View commit details
    Browse the repository at this point in the history