Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include sys/auxv.h in getexepath #66874

Merged
merged 1 commit into from
Mar 19, 2022
Merged

Include sys/auxv.h in getexepath #66874

merged 1 commit into from
Mar 19, 2022

Conversation

am11
Copy link
Member

@am11 am11 commented Mar 19, 2022

It was using slow (procfs) path because of this missing include.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 19, 2022
@ghost
Copy link

ghost commented Mar 19, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

It was using slow (procfs) path because of this missing include.

Author: am11
Assignees: -
Labels:

area-Infrastructure-libraries, community-contribution

Milestone: -

@am11
Copy link
Member Author

am11 commented Mar 19, 2022

cc @jkotas, @vitek-karas, I noticed that on a system with ill-behaving procfs, where corehost was aborting like this:

$ dotnet --info
Failed to resolve full path of the current executable []

$ cat /proc/self/exe
cat: /proc/self/exe: Bad file descriptor
cat: /proc/self/exe: Bad file descriptor

This fix might also help #47280.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas
Copy link
Member

jkotas commented Mar 19, 2022

Test failure is #64964

@jkotas jkotas merged commit 14304eb into dotnet:main Mar 19, 2022
radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 18, 2022
@am11 am11 deleted the feature/minipal branch November 29, 2022 08:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants