Reenable SslStreamNetworkStreamTests on OSX #66393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsFixes #46837 For now, just checking if test passes on CI
|
|
CI failure is #65817 |
stephentoub
approved these changes
Mar 10, 2022
|
We should watch this closely. AFAIK there are no changes what would really fix it and in the past the tests were just unreliable. So one clean pass may not be sufficient. |
|
I have run the tests in a loop a few hundred times on OSX box, no failures. Let's merge this and monitor the test failures. |
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
The underlying issue has been likely fixed by other changes
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46837
Essentially reverts #47025
For now, just checking if test passes on CI