-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement {Try}HashData on asymmetric algorithms #66349
Conversation
Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones Issue DetailsAn implementation to consider for #66228, if we want to go down this path.
|
@@ -79,9 +79,9 @@ public static void TestShimProperties() | |||
} | |||
|
|||
[Fact] | |||
public static void TestShimOverloads() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly unrelated from this PR, but the "overloads" in the test names didn't seem correct to me. Consider this a "rider" pull request. 😄
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/DSA.cs
Show resolved
Hide resolved
Open task right now is, for my own education and interest, get a JIT dump for |
First, a preface: I am by no means experienced with JIT dumps. But I took a stab at looking at a JIT dump of this pattern: using System;
Console.WriteLine(new FooImpl().Bar());
interface IMarker {}
public abstract class FooBase {
public virtual int Bar()
{
if (this is IMarker)
{
Console.WriteLine("marker");
return 1;
}
else
{
Console.WriteLine("no marker");
return 1;
}
}
}
public sealed class FooImpl : FooBase, IMarker
{
} At least on macOS ARM, I don't see the
I'm not sure how much we care, but it was a fun exercise. @bartonjs I am marking this as "ready", but if we want to go back to overrides because we end up with interface checks, or if we can figure out how my testing was wrong, I am happy to adjust. |
An implementation to consider for #66228, if we want to go down this path.