Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid RegexCode/RegexWriter for all engines other than RegexInterpreter #65986

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Avoid RegexCode/RegexWriter for all engines other than RegexInterpreter #65986

merged 2 commits into from
Mar 2, 2022

Conversation

stephentoub
Copy link
Member

Fixes #62450

@stephentoub stephentoub requested a review from joperezr March 1, 2022 02:04
@ghost ghost assigned stephentoub Mar 1, 2022
@ghost
Copy link

ghost commented Mar 1, 2022

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #62450

Author: stephentoub
Assignees: -
Labels:

area-System.Text.RegularExpressions
Milestone: -

joperezr
joperezr approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments but this looks great otherwise. Thanks @stephentoub!

@stephentoub stephentoub force-pushed the removeregexwriter branch 2 times, most recently from 085b95a to e8b85fc Compare March 1, 2022 21:42
@stephentoub stephentoub merged commit 093bdc4 into dotnet:main Mar 2, 2022
@stephentoub stephentoub deleted the removeregexwriter branch March 2, 2022 12:52
@runfoapp runfoapp bot mentioned this pull request Mar 2, 2022
Closed
@elinor-fung elinor-fung mentioned this pull request Mar 2, 2022
Closed
@radical radical mentioned this pull request Mar 2, 2022
Open
This was referenced Mar 8, 2022
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joperezr joperezr joperezr approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.Text.RegularExpressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid RegexWriter for RegexOptions.Compiled, RegexOptions.NonBacktracking, and source generator
2 participants
@stephentoub @joperezr