support WindowsPrincipal in HttpListenerWebSocketContext #65746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/ncl |
stephentoub
reviewed
Feb 24, 2022
| @@ -101,7 +101,15 @@ public class HttpListenerWebSocketContext : WebSocketContext | |||
| else | |||
| { | |||
| // AuthenticationSchemes.Digest, AuthenticationSchemes.Negotiate, AuthenticationSchemes.NTLM. | |||
| #if (WINDOWS) | |||
| if (user.Identity is WindowsIdentity windowsIdentity) | |||
There was a problem hiding this comment.
Don't we know user.Identity is a WindowsIdentity here? The .NET Framework implementation just casts:
https://referencesource.microsoft.com/#System/net/System/Net/WebSockets/HttpListenerWebSocketContext.cs,149
wfurt
reviewed
Feb 24, 2022
src/libraries/System.Net.HttpListener/src/System/Net/WebSockets/HttpListenerWebSocketContext.cs
Outdated
Show resolved
Hide resolved
wfurt
approved these changes
Feb 25, 2022
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Mar 30, 2022
* support WindowsPrincipal in HttpListenerWebSocketContext * user Identity is known as instance of WindowsIdentity * use TARGET_WINDOWS preprocessor
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63738