Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ping tests on OSX #65508

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Fix ping tests on OSX #65508

merged 1 commit into from
Feb 17, 2022

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Feb 17, 2022

Fixes #64963

Made sure the tests check for both IPv4 and IPv6 local addresses when pinging localhost.

Test against both IPv4 and IPv6 addresses when pinging using "localhost" hostname
@ghost
Copy link

ghost commented Feb 17, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #64963

Made sure the tests check for both IPv4 and IPv6 local addresses when pinging localhost.

Author: rzikm
Assignees: -
Labels:

area-System.Net

Milestone: -

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rzikm
Copy link
Member Author

rzikm commented Feb 17, 2022

No relevant CI failures

@rzikm rzikm merged commit 643e08d into dotnet:main Feb 17, 2022
@rzikm rzikm removed their assignment Feb 17, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 19, 2022
@karelz karelz added this to the 7.0.0 milestone Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Net.NetworkInformation.Tests.PingTest.SendPingWithHostAndTimeoutAndBuffer failing on OSX
4 participants