-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Group 3] Enable nullable annotations for Microsoft.Extensions.Hosting.Abstractions
#65403
Changes from all commits
90b775b
3a5a586
0ba17cc
e2a9da3
6fc5e66
7ee6d30
a8318be
dabdada
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -26,7 +26,7 @@ public interface IHostingEnvironment | |||||||||||||||||||||||||
/// Gets or sets the name of the application. This property is automatically set by the host to the assembly containing | ||||||||||||||||||||||||||
/// the application entry point. | ||||||||||||||||||||||||||
/// </summary> | ||||||||||||||||||||||||||
string ApplicationName { get; set; } | ||||||||||||||||||||||||||
string? ApplicationName { get; set; } | ||||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @eerhardt This one seems odd to be nullable, similar to EnvironmentName above, this is set automatically by the host There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Given the current code, this annotation is correct as there are scenarios where it can be null: runtime/src/libraries/Microsoft.Extensions.Hosting/src/HostBuilder.cs Lines 202 to 213 in 05cb7f5
|
||||||||||||||||||||||||||
|
||||||||||||||||||||||||||
/// <summary> | ||||||||||||||||||||||||||
/// Gets or sets the absolute path to the directory that contains the application content files. | ||||||||||||||||||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will probably have problems with these two in the
Hosting
PR, but we can deal with it then. I think the intention here is that these two properties are notnull
.