Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: fix containment safety check in LowerHWIntrinsicGetElement #64960

Merged
merged 1 commit into from
Feb 8, 2022
Merged

JIT: fix containment safety check in LowerHWIntrinsicGetElement #64960

merged 1 commit into from
Feb 8, 2022

Conversation

AndyAyersMS
Copy link
Member

Missing call to IsSafeToContainMem was causing us to mistakenly think
an operand was going to be contained when it wasn't.

Fixes #64918

@AndyAyersMS
JIT: fix containment safety check in LowerHWIntrinsicGetElement
efbdbbb 
Missing call to IsSafeToContainMem was causing us to mistakenly think
an operand was going to be contained when it wasn't.

Fixes dotnet#64918
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 8, 2022
@ghost ghost assigned AndyAyersMS Feb 8, 2022
@ghost
Copy link

ghost commented Feb 8, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Missing call to IsSafeToContainMem was causing us to mistakenly think
an operand was going to be contained when it wasn't.

Fixes #64918

Author: AndyAyersMS
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@AndyAyersMS
Copy link
Member Author

@tannergooding PTAL
cc @dotnet/jit-contrib

BruceForstall
BruceForstall approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndyAyersMS
Copy link
Member Author

There are some other "unguarded" uses of IsContainableMemoryOp in Lowering::OptimizeConstCompare which look like they might lead to trouble, but I'm not 100% sure about this, as we then go on to sort of preference what follows assuming this containment will happen. Could be if we end up being wrong about containment, we end up with sub-optimal but not incorrect code.

I think I'll leave those as is for now and look at the impact of adding the extra guarding separately.

@AndyAyersMS AndyAyersMS merged commit b305a17 into dotnet:main Feb 8, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

@tannergooding tannergooding tannergooding approved these changes

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@AndyAyersMS AndyAyersMS

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System.Numerics.Vectors.Tests: Assertion failed 'intrinsicId == NI_Vector128_GetElement'
4 participants
@AndyAyersMS @jakobbotsch @tannergooding @BruceForstall