-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip AOT of Microsoft.CodeAnalysis.CSharp.dll for WASM, due to out-of-memory issues in CI #63958
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Is #64294 needed for this? |
Yes, without it, it will fail at runtime. |
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsWe compile our wasm AOT tests on Helix rather than on AzDO due to build time concerns (it takes upwards of 3 hours to build the tests in serial all on one machine). However, the machines in Helix only have 8GiB of RAM, and some tests - notably those which consume Microsoft.CodeAnalysis.CSharp.dll will OOM the hardware before the test finishes building. This PR adds that assembly to an exclude list, which should enable us to actually build/test adequately.
|
/azp run runtime-wasm |
Azure Pipelines failed to run 1 pipeline(s). |
@radekdoulik any idea about:
|
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
Its from another attempt to solve this same problem:
|
Looks like it originally came in from @radekdoulik in #53603. |
I think back then we had these options on command line and they needed to be escaped. Now we have them in response file(s) and so we should not need to escape them anymore. |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
The System.Collections.Immutable failure isn't me
|
This seems to have largely passed the expected tests? runtime-wasm AOT tests all passed |
All the tests passed. Thank you, @directhex for fixing this! |
We compile our wasm AOT tests on Helix rather than on AzDO due to build time concerns (it takes upwards of 3 hours to build the tests in serial all on one machine). However, the machines in Helix only have 8GiB of RAM, and some tests - notably those which consume Microsoft.CodeAnalysis.CSharp.dll will OOM the hardware before the test finishes building.
This PR adds that assembly to an exclude list, which should enable us to actually build/test adequately.
Closes: #61339
Closes: #51961