-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign ILVerification.dll #63471
Sign ILVerification.dll #63471
Conversation
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsTL;DR: Given the ILVerification ships in a nuget package and as far as I understand the guideline is to strongly name assemblies (even on Core), I'm trying to get ILVerification.dll to be strongly-named. Background:
|
@jkotas I've been looking at the build artifacts, but I'm having trouble locating the ILVerification assembly to check that it got signed. Would you know how to find it? |
I am not able to find it either. I think the binary is missing in the CI published artifacts. |
Thanks. Can this be merged with a single sign-off? |
Yep |
I would recommend setting
Perhaps we should consider moving that default up. |
|
TL;DR: Given the ILVerification ships in a nuget package and as far as I understand the guideline is to strongly name assemblies (even on Core), I'm trying to get ILVerification.dll to be strongly-named.
Background:
Over the break, I've revived the roslyn PR to use ILVerify in the compiler tests (side-by-side with PEVerify).
It's working pretty well, but it hit two issues related to ILVerification.dll not having a strong name:
CSC : error CS8002: Referenced assembly 'ILVerification, Version=6.0.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name. [D:\a\_work\1\s\src\Compilers\Test\Core\Microsoft.CodeAnalysis.Test.Utilities.csproj]
)System.IO.FileLoadException : Could not load file or assembly 'ILVerification, Version=6.0.0.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. A strongly-named assembly is required. (Exception from HRESULT: 0x80131044)
)Relates to dotnet/roslyn#22872