Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a crash bug #63222

Merged
merged 2 commits into from
Dec 30, 2021
Merged

Fixing a crash bug #63222

merged 2 commits into from
Dec 30, 2021

Conversation

masonwheeler
Copy link
Contributor

ILVerify will currently crash with a NullReferenceException if parsing a type signature referring to an assembly that was not specified as a -r parameter.

Fixes #63221.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 30, 2021
@jkotas jkotas added the area-Tools-ILVerification Issues related to ilverify tool and IL verification in general label Dec 30, 2021
@ghost
Copy link

ghost commented Dec 30, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

ILVerify will currently crash with a NullReferenceException if parsing a type signature referring to an assembly that was not specified as a -r parameter.

Fixes #63221.

Author: masonwheeler
Assignees: -
Labels:

area-crossgen2-coreclr, area-ILVerification, community-contribution
Milestone: -

@masonwheeler
Copy link
Contributor Author

Fixes #62711

jkotas
jkotas approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas jkotas merged commit d0631be into dotnet:main Dec 30, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi left review comments

@jkotas jkotas jkotas approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky

Assignees
No one assigned
Labels
area-Tools-ILVerification Issues related to ilverify tool and IL verification in general community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad data can cause ILVerify to throw NRE
3 participants
@masonwheeler @CyrusNajmabadi @jkotas