-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Spans on Go() methods for Code Gen engines #62324
Conversation
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsContributes to #59629 Finishing the work to use Spans over the Emitter and Compiler now that @stephentoub work has been merged.
|
After this changes are in, for all 3 engines (interpreted, compiler, and emitter) we should only be using
|
...libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexCompiler.cs
Show resolved
Hide resolved
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. There's going to be some conflicts with #62318, but whoever merges second can resolve those easily (mostly this is changing code that gets deleted there).
I'm fine being the one that resolves the conflicts so feel free to go ahead and merge, and I'll react to the changes. |
@joperezr, why don't you go ahead and get yours merged. Mine's blocked on a potential mono interpreter issue. |
5e00ef1
to
92f761c
Compare
92f761c
to
7dd18f3
Compare
Contributes to #59629
Finishing the work to use Spans over the Emitter and Compiler now that @stephentoub work has been merged.