-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating src/tests/Interop/PInvoke/Generics/GenericsNative.Vector* to annotate individual methods as requiring AVX #61259
Updating src/tests/Interop/PInvoke/Generics/GenericsNative.Vector* to annotate individual methods as requiring AVX #61259
Conversation
… annotate individual methods as requiring AVX
can this address #47317 as well? |
Possibly but also possibly not entirely. We'd have to check and see if a method that uses If it only allows intrinsic usage and doesn't automatically opt into using __m256 based block copy; then it should work for the methods that are actually being called today. Otherwise, we'd need to split into "__m256" vs "user-defined 256-bit struct" and have |
We're no longer setting |
@AndyAyersMS, Windows doesn't require this at all and never has. It was specified purely so If we want/need to handle the case of testing |
Ok, thanks. |
Just anotate couple other methods which I need, based on dotnet#61259 methodology
Just anotate couple other methods which I need, based on #61259 methodology
This is an "improved" version of #61229 that only opts specific methods into requiring AVX rather than forcing it for the entire compilation