Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][debugger] Fix evaluation of a static class attribute; using current namespace for evaluation #61252

Merged
merged 24 commits into from
Nov 17, 2021
Merged

[wasm][debugger] Fix evaluation of a static class attribute; using current namespace for evaluation #61252

merged 24 commits into from
Nov 17, 2021

Commits on Nov 5, 2021

  1. Using current namespace as the default place to serach for the resolv… 

    …ed class.
    @ilonatommy
    ilonatommy committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    fab24e5 View commit details
    Browse the repository at this point in the history

  2. Add tests for static class, static fields and pausing in async method.

    @ilonatommy
    ilonatommy committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    66b56a7 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. Added tests for class evaluation.

    @ilonatommy
    ilonatommy committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    782a107 View commit details
    Browse the repository at this point in the history

  2. Fixing support to the current namespace and adding tests for it

    @thaystg
    thaystg committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    4119de3 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. Merge branch 'add-static-attribute-support' of https://github.com/ilo… 

    …natommy/runtime into add-static-attribute-support
    @ilonatommy
    ilonatommy committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    e275144 View commit details
    Browse the repository at this point in the history

  2. Assuing that we search within the current assembly first. Removed tes… 

    …ts that fail in Consol App.
    @ilonatommy
    ilonatommy committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    ee19014 View commit details
    Browse the repository at this point in the history

  3. Remove a test-duplicate that was not testing static class or static f… 

    …ields.
    @ilonatommy
    ilonatommy committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    89bdc49 View commit details
    Browse the repository at this point in the history

  4. Fixing indentation.

    @ilonatommy
    ilonatommy committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    5ce0f57 View commit details
    Browse the repository at this point in the history

  5. Refixing indentation.

    @ilonatommy
    ilonatommy committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    62d18b6 View commit details
    Browse the repository at this point in the history

  6. Refix indentations again.

    @ilonatommy
    ilonatommy committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    ce177fd View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2021

  1. Applied the advice about adding new blank lines.

    @ilonatommy
    ilonatommy committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    cb32402 View commit details
    Browse the repository at this point in the history

  2. Changed the current assembly check.

    @ilonatommy
    ilonatommy committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    ed2577e View commit details
    Browse the repository at this point in the history

  3. Extracting the check from the loop. One time check is enough.

    @ilonatommy
    ilonatommy committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    01f46d5 View commit details
    Browse the repository at this point in the history

  4. Simplifying multiple test cases into one call.

    @ilonatommy
    ilonatommy committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    d14367d View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2021

  1. Using local function as per review suggestion.

    @ilonatommy
    ilonatommy committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    8a82380 View commit details
    Browse the repository at this point in the history

  2. Added test that was skipped by mistake.

    @ilonatommy
    ilonatommy committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    7f24d47 View commit details
    Browse the repository at this point in the history

  3. Added looking for the namespace in all assemblies because there is a … 

    …chance it will be located out of the current assembly.
    @ilonatommy
    ilonatommy committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    367c431 View commit details
    Browse the repository at this point in the history

  4. Extracting value based on the current frame, not the top of stack loc… 

    …ation.
    @ilonatommy
    ilonatommy committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    55479c8 View commit details
    Browse the repository at this point in the history

  5. Test for classes evaluated from different frames.

    @ilonatommy
    ilonatommy committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    5f5cdf6 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Fixing indentation and spaces.

    @ilonatommy
    ilonatommy committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    7151177 View commit details
    Browse the repository at this point in the history

  2. Applied review comments for values evaluation.

    @ilonatommy
    ilonatommy committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    5fc759e View commit details
    Browse the repository at this point in the history

  3. Compressed two tests into one with MemberData.

    @ilonatommy
    ilonatommy committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    3661c0e View commit details
    Browse the repository at this point in the history

  4. Added test case of type without namespace (failing).

    @ilonatommy
    ilonatommy committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    66ed5c2 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Addressed Ankit advices from the review.

    @ilonatommy
    ilonatommy committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    136f69a View commit details
    Browse the repository at this point in the history