Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failures happening in CI on PEImage::LoadFlat/LoadImage #60277

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

elinor-fung
Copy link
Member

Take write lock in PEImage::LoadFlat/LoadImage

@ghost
Copy link

ghost commented Oct 12, 2021

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Take write lock in PEImage::LoadFlat/LoadImage

Author: elinor-fung
Assignees: -
Labels:

area-AssemblyLoader-coreclr

Milestone: -

@elinor-fung elinor-fung merged commit debe671 into dotnet:main Oct 12, 2021
@elinor-fung elinor-fung deleted the fixAssertFailure branch October 12, 2021 02:43
@VSadov
Copy link
Member

VSadov commented Oct 12, 2021

Right! The lock is needed at least to make that assert happy.
Not sure why CI did not catch it. Strange. Thanks!

@BruceForstall
Copy link
Member

Does this fix all the Assert failure(PID 3364 [0x00000d24], Thread: 5828 [0x16c4]): m_pLayoutLock->IsWriterLock() failures?

@VSadov
Copy link
Member

VSadov commented Oct 12, 2021

@BruceForstall - Yes, it fixes the IsWriterLock assert failures.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants