Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore NOPs in impIsTailCallILPattern #58626

Closed
wants to merge 1 commit into from
Closed

Ignore NOPs in impIsTailCallILPattern #58626

wants to merge 1 commit into from

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Sep 3, 2021 •
edited
Loading

Fixes #58622
codegen for bar:
Before:

G_M34324_IG01:        
IN0004: 000000 sub      rsp, 40
G_M34324_IG02:        
IN0001: 000004 cmp      dword ptr [rcx], ecx
IN0002: 000006 call     [bar@12:bar(byref):this]
IN0003: 00000C nop
G_M34324_IG03:        
IN0005: 00000D add      rsp, 40
IN0006: 000011 ret

After:

G_M34324_IG01:        
G_M34324_IG02:        
IN0001: 000000 align    [0 bytes]
G_M34324_IG03: 
IN0002: 000000 jmp      SHORT G_M34324_IG03

/cc @jakobbotsch @dotnet/jit-contrib

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 3, 2021
@ghost
Copy link

ghost commented Sep 3, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #58622
codegen for bar:
Before:

G_M34324_IG01:        
IN0004: 000000 sub      rsp, 40
G_M34324_IG02:        
IN0001: 000004 cmp      dword ptr [rcx], ecx
IN0002: 000006 call     [bar@12:bar(byref):this]
IN0003: 00000C nop
G_M34324_IG03:        
IN0005: 00000D add      rsp, 40
IN0006: 000011 ret

After:

G_M34324_IG01:        
G_M34324_IG02:        
IN0001: 000000 align    [0 bytes]
G_M34324_IG03: 
IN0002: 000000 jmp      SHORT G_M34324_IG03
Author: EgorBo
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch jakobbotsch mentioned this pull request Sep 3, 2021
Closed
@EgorBo
Copy link
Member Author

EgorBo commented Sep 3, 2021

Closing, #58622 (comment)

@EgorBo EgorBo closed this Sep 3, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow tail call optimization for call + nop + ret
2 participants
@EgorBo @jakobbotsch