[release/6.0] [Libraries][Android] Fix alignment for padding System.Decimal #58380
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
lambdageek,
thaystg and
vargaz
as code owners
|
Tagging subscribers to 'arch-android': @steveisok, @akoeplinger Issue DetailsBackport of #57978 to release/6.0 /cc @mdh1418 Customer ImpactWhile running library tests for mobile, it was discovered that expected alignment for padding System.Decimal struct was incorrect for Linux x86 as the tests were not yet modified to fully accommodate non-Windows platforms. Furthermore, mono had been following CoreCLR's special case for System.Decimal, but mono's special case was not removed when CoreCLR's special case was removed. Modifies the tests that checks alignment of System.Decimal within structs Without this PR, the System.Decimal special case marshal handling would be unnecessary and the tests would continue to fail on Android x86 TestingThe tests are fixed with this PR RiskLow, this corrects the padding/alignment for structs using System.Decimal on non-Windows x86 platforms
|
ghost
locked as resolved and limited conversation to collaborators
Backport of #57978 to release/6.0
/cc @mdh1418
Customer Impact
While running library tests for mobile, it was discovered that expected alignment for padding System.Decimal struct was incorrect for Linux x86 as the tests were not yet modified to fully accommodate non-Windows platforms. Furthermore, mono had been following CoreCLR's special case for System.Decimal, but mono's special case was not removed when CoreCLR's special case was removed.
Modifies the tests that checks alignment of System.Decimal within structs
Removes special casing from mono's marshal implementation
Without this PR, the System.Decimal special case marshal handling would be unnecessary and the tests would continue to fail on Android x86
Testing
The tests are fixed with this PR
Risk
Low, this corrects the padding/alignment for structs using System.Decimal on non-Windows x86 platforms