Refactor fgInitArgInfo to track non standard arg kinds #58324
Conversation
This changes the JIT to keep track of the non standard arg kinds that are added to the arg info table. We currently have several places (`fgResetArgInfo`, morph for tailcall-via-helpers) that make "blind" assumptions on which arg is which depending on certain flags set in the call. This change makes `fgResetArgInfo` more general and allows us to add asserts to the tailcall logic to verify that we are removing the args we expect.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsThis changes the JIT to keep track of the non standard arg kinds that This helps support #56669, where I need to be able to discern different No SPMI diffs. cc @dotnet/jit-contrib
|
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
This changes the JIT to keep track of the non standard arg kinds that
are added to the arg info table. We currently have several places
(
fgResetArgInfo, morph for tailcall-via-helpers) that make "blind"assumptions on which arg is which depending on certain flags set in the
call. This change makes
fgResetArgInfomore general and allows us toadd asserts to the tailcall logic to verify that we are removing the
args we expect.
This helps support #56669, where I need to be able to discern different
non standard args during the tailcall-to-recursion transformation.
No SPMI diffs.
cc @dotnet/jit-contrib