JIT: add PGO random stress testing support #58294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable the previously added RandomGDV for various PGO CI pipelines. Add a new `JitRandomEdgeCount` mode to provide random but plausible PGO data for edge counters. Because of the way sparse edge counting works this data will most ofen end up providing a consistent set of block counts. Enable this mode in PGO pipelines, and also a mode that randomzies both counts and GDV selections.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsEnable the previously added RandomGDV for various PGO CI pipelines. Add a new Enable this mode in PGO pipelines, and also a mode that randomzies both
|
|
cc @dotnet/jit-contrib |
|
/azp run runtime-coreclr pgo |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr libraries-pgo |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Sample of counts (from 8queen's |
|
Here's the empirical count distribution CDF I gathered from the
|
|
/azp run runtime-coreclr pgo |
|
/azp run runtime-coreclr libraries-pgo |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr pgo |
|
No pipelines are associated with this pull request. |
|
/azp run runtime-coreclr pgo |
|
/azp run runtime-coreclr libraries-pgo |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
BruceForstall
approved these changes
Aug 28, 2021
|
Looks like a couple of asserts in libraries tests so far. The runtime tests don't seem to be using the new modes, there are only the existing 4 modes per isa/os. Not sure what's up there. |
|
Non-pgo failures look like known issues. I will open issues for the new pgo mode failures. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the previously added RandomGDV for various PGO CI pipelines.
Add a new
JitRandomEdgeCountmode to provide random but plausiblePGO data for edge counters. Because of the way sparse edge counting works
this data will most ofen end up providing a consistent set of block counts.
Enable this mode in PGO pipelines, and also a mode that randomzies both
counts and GDV selections.