Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use OutputRid in test projects #58166

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Use OutputRid in test projects #58166

merged 1 commit into from
Aug 26, 2021

Conversation

am11
Copy link
Member

@am11 am11 commented Aug 26, 2021 •
edited
Loading

To test an outerloop test leg failure.

Fixes #55657

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 26, 2021
@am11
Copy link
Member Author

am11 commented Aug 26, 2021

@ViktorHofer, once normal CI / priority 0 tests are green'ish, can we trigger outerloop tests in the PR for priority 1 tests; where matrix has some interesting platforms?

@ViktorHofer
Copy link
Member

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@am11 am11 marked this pull request as ready for review August 26, 2021 13:26
@am11
Copy link
Member Author

am11 commented Aug 26, 2021

failures are unrelated:

@am11 am11 mentioned this pull request Aug 26, 2021
Closed
@ghost
Copy link

ghost commented Aug 26, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

To test an outerloop test leg failure.

Fixes #55657

Author: am11
Assignees: -
Labels:

area-Infrastructure, community-contribution
Milestone: -

trylek
trylek approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ViktorHofer ViktorHofer merged commit 16de9a2 into dotnet:main Aug 26, 2021
@am11 am11 deleted the feature/rid branch August 26, 2021 19:08
@am11
Copy link
Member Author

am11 commented Aug 30, 2021

@ViktorHofer, linux-musl outerloop legs are failing in release/6.0. Is it a valid reason to backport this change?

@hoyosjs
Copy link
Member

hoyosjs commented Aug 30, 2021

/backport to release/6.0

@am11 it is, as it is relevant for servicing exercises. Thanks.

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1181101738

@github-actions github-actions bot mentioned this pull request Aug 30, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@trylek trylek trylek approved these changes

Assignees
No one assigned
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate CORE_ROOT failing for linux_musl arm/arm64
6 participants
@am11 @ViktorHofer @hoyosjs @jkoritzinsky @trylek @danmoseley