Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FileProviders.Physical.GetLastWriteTimeUtc crash #57415

Merged
2 commits merged into from
Aug 15, 2021

Conversation

maxkoshevoi
Copy link
Contributor

@maxkoshevoi maxkoshevoi commented Aug 14, 2021

Some tests are failing because of a recent changes.
Example: failing test

Updated the code, so there won't be an NRE

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 14, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Extensions-FileSystem and removed community-contribution Indicates that the PR has been added by a community member labels Aug 14, 2021
@ghost
Copy link

ghost commented Aug 14, 2021

Tagging subscribers to this area: @maryamariyan, @dotnet/area-extensions-filesystem
See info in area-owners.md if you want to be subscribed.

Issue Details

Some tests are failing because of a recent changes. Example: https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-57395-merge-0f3646ab75284a6cb3/Microsoft.Extensions.FileProviders.Physical.Tests/1/console.29678691.log?sv=2019-07-07&se=2021-09-03T19%3A34%3A21Z&sr=c&sp=rl&sig=6WlTuWWS7AQohTGzb24%2BQAjaIIGcksFMs%2Bgzchsez3k%3D

Updated the code, so there won't be an NRE

Author: maxkoshevoi
Assignees: -
Labels:

area-Extensions-FileSystem

Milestone: -

Copy link
Member

@jozkee jozkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@jozkee jozkee added this to the 6.0.0 milestone Aug 14, 2021
@ghost
Copy link

ghost commented Aug 14, 2021

Hello @jozkee!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit cb61f93 into dotnet:main Aug 15, 2021
@maxkoshevoi maxkoshevoi deleted the mk/fix-physical-provider branch August 15, 2021 00:57
@ghost ghost locked as resolved and limited conversation to collaborators Sep 14, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants