Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve SNI handling when IP is passed in as DnsEndPoint to QuicListener #57255

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Aug 12, 2021

contributes to #57169 when somebody is trying to bypass DNS.
HttpClient will always use DnsEndPoint even if the URI is IP specific address.

Since I bump to it while writing test, I added more validation to listener.
fixes #57091

@ghost
Copy link

ghost commented Aug 12, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

contributes to #57169 when somebody is trying to bypass DNS.
HttpClient will always use DnsEndPoint even if the URI is IP specific address.

Since I bump to it while writing test, I added more validation to listener.
fixes #57091

Author: wfurt
Assignees: -
Labels:

area-System.Net.Quic

Milestone: -

@wfurt wfurt requested a review from a team August 12, 2021 01:25
@wfurt wfurt self-assigned this Aug 12, 2021
@ghost
Copy link

ghost commented Aug 12, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

contributes to #57169 when somebody is trying to bypass DNS.
HttpClient will always use DnsEndPoint even if the URI is IP specific address.

Since I bump to it while writing test, I added more validation to listener.
fixes #57091

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Quic

Milestone: -

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@wfurt
Copy link
Member Author

wfurt commented Aug 13, 2021

FileProviders.Physical.Tests failure unrelated. Probably variant of #57266.

@wfurt wfurt merged commit 42af636 into dotnet:main Aug 13, 2021
@wfurt wfurt deleted the sni_57169 branch August 13, 2021 17:55
@karelz karelz added this to the 6.0.0 milestone Aug 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullReferenceException if QuicListenerOptions.ListenEndPoint is not set
3 participants