Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analyzer, docs file packaging and don't overbuild runtime.native IO.Ports packages. #57118

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Aug 10, 2021

This commit fixes analyzers which were dropped from the package during
the clean-up of pkgprojs and missing documentation files.

  1. Analyzers were dropped from the package because the BeforePack
    hook wasn't respected. This happens when the NuGet Pack nuget package
    is referenced which then gets imported before the packaging.targets
    file. The BeforePack property needs to be set in a props file if
    NuGet's targets file isn't used from the SDK but from its package.
  2. Documentation files were dropped as the
    DefaultAllowedOutputExtensionsInPackageBuildOutputFolder property
    didn't include the .xml extension.
  3. runtime.native.System.IO.Ports.csproj is referenced both in the src.proj
    traversal project and in System.IO.Ports.csproj. The latter reference is
    necessary in order to make it appear as a dependency in the
    System.IO.Ports nuget package. The ProjectReference was missing the
    BuildReferences=false attribute and hence the
    runtime.native.System.IO.Ports project was built twice which resulted
    in multiple concurrent builds likely with different global properties.

This commit fixes analyzers which were dropped from the package during
the clean-up of pkgprojs and missing documentation files.

1. Analyzers were dropped from the package because the BeforePack
   hook wasn't respected. This happens when the NuGet Pack nuget package
   is referenced which then gets imported before the packaging.targets
   file. The BeforePack property needs to be set in a props file if
   NuGet's targets file isn't used from the SDK but from its package.
2. Documentation files were dropped as the
   DefaultAllowedOutputExtensionsInPackageBuildOutputFolder property
   didn't include the .xml extension.
@ghost
Copy link

ghost commented Aug 10, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

This commit fixes analyzers which were dropped from the package during
the clean-up of pkgprojs and missing documentation files.

  1. Analyzers were dropped from the package because the BeforePack
    hook wasn't respected. This happens when the NuGet Pack nuget package
    is referenced which then gets imported before the packaging.targets
    file. The BeforePack property needs to be set in a props file if
    NuGet's targets file isn't used from the SDK but from its package.
  2. Documentation files were dropped as the
    DefaultAllowedOutputExtensionsInPackageBuildOutputFolder property
    didn't include the .xml extension.
Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries

Milestone: -

@ViktorHofer ViktorHofer changed the title Fix analyzer and docs file packaging Fix analyzer, docs file packaging and don't overbuild runtime.native IO.Ports packages. Aug 10, 2021
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Aug 10, 2021

@dotnet/dnceng @ilyas1974 do we have an issue open for super slow machines running on CI? CoreCLR Product Build OSX x64 checked took 2 hours to just build half of the runtime and then timed out (2 hour cap on the leg).

https://dev.azure.com/dnceng/public/_build/results?buildId=1285173&view=logs&jobId=1f8f000c-1adc-5434-677a-95dd9e006aba&j=1f8f000c-1adc-5434-677a-95dd9e006aba&t=2945a4f3-4f84-5b54-c962-533fbace1ff1

@jakubstilec
Copy link

@ViktorHofer there is no open issue for this. This is an issue on AzDO Mac OS pool, not on helix queues. Checking.

@ViktorHofer ViktorHofer merged commit 9722a6a into dotnet:main Aug 10, 2021
@ViktorHofer ViktorHofer deleted the PackageFixes branch August 10, 2021 12:38
@jakubstilec
Copy link

jakubstilec commented Aug 10, 2021

I retried and the failed job and it finished in 36 minutes. It looks like only temporary issue with one MacOS node. In a case this happens again, affected node was:

Agent name: 'Azure Pipelines 9'
Agent machine name: 'Mac-1628587082288'

@ViktorHofer
Copy link
Member Author

It depends on the machine being used in the pool. We have been seeing this multiple times over the last months. It might make sense to go through the build data to see how often this is happening?

@jakubstilec
Copy link

I created a work item for it https://github.com/dotnet/core-eng/issues/14027

Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants