-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix analyzer, docs file packaging and don't overbuild runtime.native IO.Ports packages. #57118
Conversation
This commit fixes analyzers which were dropped from the package during the clean-up of pkgprojs and missing documentation files. 1. Analyzers were dropped from the package because the BeforePack hook wasn't respected. This happens when the NuGet Pack nuget package is referenced which then gets imported before the packaging.targets file. The BeforePack property needs to be set in a props file if NuGet's targets file isn't used from the SDK but from its package. 2. Documentation files were dropped as the DefaultAllowedOutputExtensionsInPackageBuildOutputFolder property didn't include the .xml extension.
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsThis commit fixes analyzers which were dropped from the package during
|
@dotnet/dnceng @ilyas1974 do we have an issue open for super slow machines running on CI? |
@ViktorHofer there is no open issue for this. This is an issue on AzDO Mac OS pool, not on helix queues. Checking. |
I retried and the failed job and it finished in 36 minutes. It looks like only temporary issue with one MacOS node. In a case this happens again, affected node was:
|
It depends on the machine being used in the pool. We have been seeing this multiple times over the last months. It might make sense to go through the build data to see how often this is happening? |
I created a work item for it https://github.com/dotnet/core-eng/issues/14027 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit fixes analyzers which were dropped from the package during
the clean-up of pkgprojs and missing documentation files.
hook wasn't respected. This happens when the NuGet Pack nuget package
is referenced which then gets imported before the packaging.targets
file. The BeforePack property needs to be set in a props file if
NuGet's targets file isn't used from the SDK but from its package.
DefaultAllowedOutputExtensionsInPackageBuildOutputFolder property
didn't include the .xml extension.
traversal project and in System.IO.Ports.csproj. The latter reference is
necessary in order to make it appear as a dependency in the
System.IO.Ports nuget package. The ProjectReference was missing the
BuildReferences=false
attribute and hence theruntime.native.System.IO.Ports project was built twice which resulted
in multiple concurrent builds likely with different global properties.