Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable System.Drawing.Common tests for mobile workloads and skip a few other tests #57114

Merged
merged 7 commits into from
Aug 13, 2021

Conversation

steveisok
Copy link
Member

@steveisok steveisok commented Aug 10, 2021

Since the library is PNSE by default, make sure the tests do not run on mobile.
Also skips a few other tests.

Closes #57184

Since the library is PNSE by default, make sure the tests do not run on mobile.
@ghost
Copy link

ghost commented Aug 10, 2021

Tagging subscribers to this area: @safern, @tarekgh
See info in area-owners.md if you want to be subscribed.

Issue Details

Since the library is PNSE by default, make sure the tests do not run on mobile.

Author: steveisok
Assignees: -
Labels:

area-System.Drawing

Milestone: -

@danmoseley
Copy link
Member

Should we have some shorthand property for '$(TargetOS)' == 'Browser' or '$(TargetOS)' == 'Android' or '$(TargetOS)' == 'iOS' or '$(TargetOS)' == 'iOSSimulator' or '$(TargetOS)' == 'tvOS' or '$(TargetOS)' == 'tvOSSimulator' or '$(TargetOS)' == 'MacCatalyst'? Or the same, without Browser. They often seem to go together.

@@ -54,7 +54,7 @@
AssemblyFile="$(RuntimeConfigParserTasksAssemblyPath)"
Condition="'$(RuntimeConfigParserTasksAssemblyPath)' != ''" />

<Target Name="GenerateRuntimeConfig" Condition="'$(OutputType)' != 'library' and '$(TargetOS)' != 'Browser'">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why do we no longer need this, or why was it introduced in the first place?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was introduced by mistake from #56486

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we skipping it on browser

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. @fanyang-mono ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasm has its own target of generating runtime config which is part of the source code. (https://github.com/dotnet/runtime/blob/main/src/mono/wasm/build/WasmApp.targets#L146) This target is for mobile testing only. But for wasm testing, the targets defined in this file will be visible to wasm tests as well. To make things clear, I added '$(TargetOS)' != 'Browser'.

@lewing
Copy link
Member

lewing commented Aug 10, 2021

browser failed with

Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully.
[13:59:16] info: browser: Console websocket connected.
[13:59:16] info: Arguments: --run,WasmTestRunner.dll,System.ServiceModel.Syndication.Tests.dll,-notrait,category=IgnoreForCI,-notrait,category=OuterLoop,-notrait,category=failing
[13:59:18] info: Initializing.....
[13:59:26] info: Discovering: System.ServiceModel.Syndication.Tests.dll (method display = ClassAndMethod, method display options = None)
[13:59:26] info: Discovered:  System.ServiceModel.Syndication.Tests.dll (found 776 of 776 test cases)
[13:59:26] info: Starting:    System.ServiceModel.Syndication.Tests.dll
[13:59:26] fail: [FAIL] System.ServiceModel.Syndication.Tests.Atom10ItemFormatterTests.WriteTo_EmptyItem_SerializesExpected
[13:59:26] info: Assert.True() Failure
[13:59:26] info: Expected: True
[13:59:26] info: Actual:   False
[13:59:26] info:    at System.ServiceModel.Syndication.Tests.Atom10ItemFormatterTests.WriteTo_EmptyItem_SerializesExpected()
[13:59:26] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
[13:59:26] info: Finished:    System.ServiceModel.Syndication.Tests.dll
[13:59:26] info: 
[13:59:26] info: === TEST EXECUTION SUMMARY ===
[13:59:26] info: Total: 1308, Errors: 0, Failed: 1, Skipped: 0, Time: 5.8885999s

which is something I have not seen before

@lewing
Copy link
Member

lewing commented Aug 10, 2021

monointerpreter failed with

System.InvalidOperationException: Collection was modified after the enumerator was instantiated.
   at System.Collections.Generic.Stack`1.Enumerator.MoveNext() in System.Collections.dll:token 0x6000267+0x1d
   at Xunit.Sdk.DisposalTracker.Dispose() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\DisposalTracker.cs:line 26
   at Xunit.Sdk.ExtensibilityPointFactory.Dispose() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\ExtensibilityPointFactory.cs:line 53
   at Xunit.Sdk.TestFramework.Dispose() in C:\Dev\xunit\xunit\src\xunit.execution\Sdk\Frameworks\TestFramework.cs:line 48
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__140_1(Object state) in System.Private.CoreLib.dll:token 0x6002da8+0x0
   at System.Threading.QueueUserWorkItemCallbackDefaultContext.Execute() in System.Private.CoreLib.dll:token 0x6002adc+0x14
   at System.Threading.ThreadPoolWorkQueue.Dispatch() in System.Private.CoreLib.dll:token 0x6002ab5+0x122
   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart() in System.Private.CoreLib.dll:token 0x6002ba0+0x67
   at System.Threading.Thread.StartCallback() in System.Private.CoreLib.dll:token 0x600272e+0xe

Are we ever going to fix this? #11063

@steveisok
Copy link
Member Author

Are we ever going to fix this? #11063

It would be nice.

@eerhardt
Copy link
Member

This will resolve #57184. We should close that issue when this is merged. Thanks for picking it up @steveisok.

@akoeplinger akoeplinger changed the title Disable System.Drawing.Common tests for mobile workloads Disable System.Drawing.Common tests for mobile workloads and skip a few other tests Aug 12, 2021
@steveisok steveisok merged commit defa26b into dotnet:main Aug 13, 2021
@steveisok steveisok deleted the disable-drawing-ci-mobile branch August 13, 2021 01:37
@ghost ghost locked as resolved and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
8 participants