Pass runtime flavor args when copying native test components in CI #57073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsBecause we were not passing this, the runtime flavor was always defaulted to coreclr when copying native test components (which chains in generating the test scripts). Even for tests conditioned to be unsupported on mono, the mono tests legs would do the work to copy all native test components, generate execution scripts, and build test wrappers (and then have to exclude running based on issues.targets). cc @dotnet/runtime-infrastructure
|
jkoritzinsky
approved these changes
Aug 9, 2021
safern
approved these changes
Aug 9, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we were not passing this, the runtime flavor was always defaulted to coreclr when copying native test components (which chains in generating the test scripts). Even for tests conditioned to be unsupported on mono, the mono tests legs would do the work to copy all native test components, generate execution scripts, and build test wrappers (and then have to exclude running based on issues.targets).
cc @dotnet/runtime-infrastructure