Fixes for text-based PGO #56986
Merged
Fixes for text-based PGO #56986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix missing indirection when reading in text-based PGO data. Prioiritize reading text-based PGO over dynamic or static PGO data, so that we can use text to provide a fixed set of PGO data when trying to isolate bugs. In the jit, give text-based PGO data the same trust level we give to dynamic PGO data.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@davidwrighton PTAL I used this to pin down the bad method over in #56689. I had an intermittent repro that failed with dynamic PGO; trying to bisect via |
jakobbotsch
reviewed
Aug 6, 2021
src/coreclr/jit/inlinepolicy.cpp
Outdated
| @@ -1684,7 +1685,8 @@ double ExtendedDefaultPolicy::DetermineMultiplier() | |||
| const double profileTrustCoef = (double)JitConfig.JitExtDefaultPolicyProfTrust() / 10.0; | |||
| const double profileScale = (double)JitConfig.JitExtDefaultPolicyProfScale() / 10.0; | |||
|
|
|||
| if (m_RootCompiler->fgPgoSource == ICorJitInfo::PgoSource::Dynamic) | |||
| if ((m_RootCompiler->fgPgoSource == ICorJitInfo::PgoSource::Dynamic) || | |||
| (m_RootCompiler->fgPgoSource == ICorJitInfo::PgoSource::Text)) | |||
There was a problem hiding this comment.
Can we add a IsPgoSourceTrustworthy (or similar) function for this?
There was a problem hiding this comment.
Sure, seems like a good idea.
jakobbotsch
approved these changes
Aug 6, 2021
davidwrighton
approved these changes
Aug 6, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing indirection when reading in text-based PGO data.
Prioiritize reading text-based PGO over dynamic or static PGO data, so that we
can use text to provide a fixed set of PGO data when trying to isolate bugs.
In the jit, give text-based PGO data the same trust level we give to dynamic
PGO data.