Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a small failure in stress test #56859

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Fix a small failure in stress test #56859

merged 1 commit into from
Aug 5, 2021

Conversation

buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented Aug 4, 2021

Fixes #50831

As mentioned in the issue comments The GetMethods method does not return methods in a particular order, such as alphabetical or declaration order. which causing the failure and suggested to just sort the list before verifying method names

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@buyaa-n buyaa-n merged commit 5a02633 into dotnet:main Aug 5, 2021
@buyaa-n buyaa-n deleted the fix_test branch August 5, 2021 16:04
@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Test failure System.Reflection.Tests.ModuleTests.GetMethods
3 participants