Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set DisableImplicitNamespaceImports_Dotnet=true to workaround sdk issue #56744

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Set DisableImplicitNamespaceImports_Dotnet=true to workaround sdk issue #56744

merged 2 commits into from
Aug 3, 2021

Conversation

safern
Copy link
Member

@safern safern commented Aug 2, 2021

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@MichalStrehovsky
Copy link
Member

Do we need both DisableImplicitNamespaceImports and DisableImplicitNamespaceImports_DotNet?

It feels like DisableImplicitNamespaceImports_DotNet is the one that is harmful. It might still be nice to be able to say <Import Include="Blah" /> in a project file and have it add a implicit using Blah to all source files #55855 (comment). It is what we did for the tools directory before it was unified at the entire repo level to DisableImplicitNamespaceImports.

@safern
Copy link
Member Author

safern commented Aug 2, 2021

Thanks @MichalStrehovsky. We were hitting this on vbproj because of: dotnet/sdk#19465 (comment)

I'll adjust as needed in order to unblock people and be able to declare global usings with the ItemGroup.

@safern
Copy link
Member Author

safern commented Aug 2, 2021

Adjusted as needed, it seems like DisableImplicitNamespaceImports_DotNet=true is all we need in the repo, tested a full build locally and it was successful with a P7 SDK.

MichalStrehovsky
MichalStrehovsky approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@safern safern merged commit 43db0fe into main Aug 3, 2021
@safern safern deleted the safern-patch-1 branch August 3, 2021 00:42
thaystg added a commit to thaystg/runtime that referenced this pull request Aug 3, 2021
@thaystg
Merge remote-tracking branch 'origin/main' into thays_fix_56249
c0e7fb2 
* origin/main: (64 commits)
  [wasm][debugger] Create test Inherited Properties (dotnet#56754)
  Mark new test as incompatible with GC Mark4781_1GcStressIncompatible (dotnet#56739)
  Ensure MetadataEnumResult is sufficiently updated by MetaDataImport::Enum (dotnet#56756)
  [mono] Remove gdb xdebug and binary writer support, it hasn't worked in a while. (dotnet#56759)
  Update windows-requirements.md (dotnet#56476)
  Update doc and generic parameter name for JsonValue.GetValue (dotnet#56639)
  [wasm][debugger] Inspect static class (dotnet#56740)
  Fix stack overflow handling issue in GC stress (dotnet#56733)
  Use ReflectionOnly as serialization mode in case dynamic code runtime feature is not supported (dotnet#56604)
  Move Windows Compat pack to NuGet pack task (dotnet#56686)
  Fix build error when building some packages (dotnet#56767)
  Simplify JIT shutdown logic in crossgen2 (dotnet#56687)
  Fix race in crossdac publishing with PGO (dotnet#56762)
  Add DictionaryKeyPolicy support for EnumConverter [dotnet#47765] (dotnet#54429)
  Use ComWrappers in some Marshal unit-tests and update platform metadata  (dotnet#56595)
  Set `DisableImplicitNamespaceImports_Dotnet=true` to workaround sdk issue (dotnet#56744)
  Make sure ServerGCHeapDetails is up to date (dotnet#56056)
  [libraries] Reenable System.Diagnostics.DiagnosticSorce.Switches.Tests on mobile (dotnet#56737)
  Disable failing arm64 win10 Graphics.FromHdc tests  (dotnet#56732)
  Match xplat event source conditions (dotnet#56435)
  ...
@ghost ghost locked as resolved and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@safern @MichalStrehovsky @akoeplinger