-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Enable InteropServices on browser-wasm #56676
Conversation
Looks like #39187 is passing but we need to disable the posix signal bits now |
cc @akoeplinger re #55643 it looks like the tests are disabled but the symbols are now missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Pushed a commit that should fix the tests build |
@vargaz can you take a look at the failures here |
Failures are here: https://dev.azure.com/dnceng/public/_build/results?buildId=1272908&view=results Console log shows: |
|
/azp run runtime |
Azure Pipelines successfully started running 1 pipeline(s). |
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
Needs [UnmanagedCallersOnly] attribute on the callback methods, and the app needs to be built with |
failure is #57221 |
No description provided.