Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark HandleProcessCorruptedStateExceptionsAttribute as obsolete #56664

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Mark HandleProcessCorruptedStateExceptionsAttribute as obsolete #56664

merged 2 commits into from
Aug 3, 2021

Conversation

jeffhandley
Copy link
Member

@jeffhandley jeffhandley commented Jul 31, 2021 •
edited
Loading

Fixes #31157

Per documentation:

Even though this attribute exists in .NET Core, since the recovery from corrupted process state exceptions is not supported, this attribute is ignored. The CLR doesn't deliver corrupted process state exceptions to the managed code.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jul 31, 2021

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #31557

Author: jeffhandley
Assignees: -
Labels:

area-System.Collections, new-api-needs-documentation
Milestone: -

@ghost
Copy link

ghost commented Jul 31, 2021

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #31157

Author: jeffhandley
Assignees: -
Labels:

area-System.Runtime, new-api-needs-documentation
Milestone: -

@jeffhandley jeffhandley added breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. and removed new-api-needs-documentation labels Jul 31, 2021
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Jul 31, 2021
@ghost
Copy link

ghost commented Jul 31, 2021

Tagging @dotnet/compat for awareness of the breaking change.

@jeffhandley jeffhandley self-assigned this Jul 31, 2021
@jeffhandley
Copy link
Member Author

Breaking change document issue: dotnet/docs#25450

@jeffhandley jeffhandley removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Aug 3, 2021
@jeffhandley jeffhandley merged commit 4fa710e into dotnet:main Aug 3, 2021
@jeffhandley jeffhandley deleted the jeffhandley/CorruptedStateExceptions-Obsolete branch August 3, 2021 23:28
thaystg added a commit to thaystg/runtime that referenced this pull request Aug 4, 2021
@thaystg
Merge remote-tracking branch 'origin/main' into thays_implement_debug…
f56ef84 
…ger_proxy_attribute

* origin/main:
  disable token info in traces. (dotnet#56780)
  [debugger] Fix debugger.break behavior (dotnet#56788)
  [mono][wasm] Allow setting env variables with '=' characters in the test runner. (dotnet#56802)
  Ecma edit for `conv.ovf.<to type>.un`. (dotnet#56450)
  Mark HandleProcessCorruptedStateExceptionsAttribute as obsolete (dotnet#56664)
  Enable SxS install of previews on Mac OS (dotnet#56797)
  CoreCLR runtime tests + Mono on the x64 iOS simulator (dotnet#43954)
  [main] Update dependencies from mono/linker (dotnet#56593)
  STJ: Fix deserialization of UInt16 properties (dotnet#56793)
@ghost ghost locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks approved these changes

Assignees

@jeffhandley jeffhandley

Labels
area-System.Runtime breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider marking HandleProcessCorruptedStateExceptionsAttribute as obsolete/hidden
2 participants
@jeffhandley @GrabYourPitchforks