JIT: don't allow negative edge weights #56651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to rounding errors or inconsistencies we may end up with unexpected ratios of profile counts. Fix one place where that was leading to a negative edge weight. Fixes dotnet#56647.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Affected test (leakwheel) was asserting about 25% of the time without this fix; ran several hundred times with the fix w/o asserting. Will run the PGO CI pipelines on this one too, as the new asserts may fire for other problematic computations. cc @dotnet/jit-contrib |
|
/azp run runtime-coreclr pgo |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-coreclr libraries-pgo |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Note the pgo pipelines will probably hit other errors; so I'm mainly checking to see that the new asserts don't fire. |
|
One leg of the runtime tests has hit this recurring xunit failure (#11063): |
|
PGO failures are all "known issues..." |
This was referenced Aug 1, 2021
|
@briansull can you approve? |
briansull
approved these changes
Aug 2, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to rounding errors or inconsistencies we may end up with unexpected
ratios of profile counts. Fix one place where that was leading to a negative
edge weight.
Fixes #56647.