Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libraries][Android] Reenable tests failing from feature switches being improperly set #56635

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ public static void ExternalCancel_Negative()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50576", TestPlatforms.Android)]
public static void ExternalCancel_AddToAny()
{
for (int test = 0; test < 3; test++)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ namespace System.ComponentModel.Tests
public class CategoryAttributeTests
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50881", TestPlatforms.Android)]
public void Ctor_Default()
{
var attribute = new CategoryAttribute();
Expand All @@ -24,7 +23,6 @@ public void Ctor_Default()
[InlineData("Misc", true)]
[InlineData("misc", false)]
[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, ".NET Framework throws a NullReferenceException")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50881", TestPlatforms.Android)]
public void Ctor_String(string category, bool expectedIsDefaultAttribute)
{
var attribute = new CategoryAttribute(category);
Expand Down Expand Up @@ -61,7 +59,6 @@ public static IEnumerable<object[]> Equals_TestData()

[Theory]
[MemberData(nameof(Equals_TestData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50881", TestPlatforms.Android)]
public void Equals_Object_ReturnsExpected(CategoryAttribute attribute, object other, bool expected)
{
Assert.Equal(expected, attribute.Equals(other));
Expand Down Expand Up @@ -90,7 +87,6 @@ public static IEnumerable<object[]> Properties_TestData()

[Theory]
[MemberData(nameof(Properties_TestData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50881", TestPlatforms.Android)]
public void Properties_Get_ReturnsExpected(Func<CategoryAttribute> attributeThunk, string expectedCategory)
{
CategoryAttribute attribute = attributeThunk();
Expand Down Expand Up @@ -129,7 +125,6 @@ public void GetLocalizedString_InvokeValueExists_ReturnsNonEmpty(string value)
[InlineData(null)]
[InlineData("")]
[InlineData("value")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50881", TestPlatforms.Android)]
public void GetLocalizedString_InvokeNoSuchValue_ReturnsNull(string value)
{
var attribute = new SubCategoryAttribute();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ public void Ctor_NullEnumClass_ThrowsArgumentNulException()
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50881", TestPlatforms.Android)]
public void Ctor_SerializationInfo_StreamingContext()
{
using (var stream = new MemoryStream())
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ public void Missing_NullSite_ThrowsArgumentNullException()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50917", TestPlatforms.Android)]
public void Satisfied_Invoke_ReturnsExpected()
{
var contract = new CompositionContract(typeof(int));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,6 @@ public void GetDescriptor_CycleMetadataBroken_HasExpectedProperties()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50917", TestPlatforms.Android)]
public void ToString_Invoke_ReturnsExpected()
{
var promise = new ExportDescriptorPromise(new CompositionContract(typeof(int)), "Origin", true, () => Enumerable.Empty<CompositionDependency>(), depdendencies =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@ public static IEnumerable<object[]> ToString_TestData()

[Theory]
[MemberData(nameof(ToString_TestData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50918", TestPlatforms.Android)]
public void ToString_Get_ReturnsExpected(CompositionContract contract, string expected)
{
Assert.Equal(expected, contract.ToString());
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/System.Composition/tests/CardinalityTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ public UsesLog(ILog log) { }
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)]
public void RequestingOneWhereMultipleArePresentFails()
{
var c = CreateContainer(typeof(LogA), typeof(LogB));
Expand All @@ -42,7 +41,6 @@ public void RequestingOneWhereMultipleArePresentFails()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)]
public void ImportingOneWhereMultipleArePresentFails()
{
var c = CreateContainer(typeof(LogA), typeof(LogB), typeof(UsesLog));
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Composition/tests/ContractTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ public void ConstraintsWithEquivalentKeysAndValuesHaveTheSameHashCode()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)]
public void FormattingTheContractPrintsConstraintKeysAndValues()
{
var mcd = new CompositionContract(typeof(AType), null, new Dictionary<string, object> { { "A", 1 }, { "B", "C" } });
Expand Down
3 changes: 0 additions & 3 deletions src/libraries/System.Composition/tests/DiscoveryTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,13 @@ public void DiscoversCustomExportAttributesUnderConventions()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)]
public void InstanceExportsOfIncompatibleContractsAreDetected()
{
var x = Assert.Throws<CompositionFailedException>(() => CreateContainer(typeof(IncompatibleRule)));
Assert.Equal("Exported contract type 'IRule' is not assignable from part 'IncompatibleRule'.", x.Message);
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)]
public void PropertyExportsOfIncompatibleContractsAreDetected()
{
var x = Assert.Throws<CompositionFailedException>(() => CreateContainer(typeof(IncompatibleRuleProperty)));
Expand Down Expand Up @@ -124,7 +122,6 @@ public class MultipleImportsOnProperty
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)]
public void MultipleImportAttributesAreDetected()
{
var c = new ContainerConfiguration()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ public class RequiresOnlyOne
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)]
public void MissingTopLevelExportMessageIsInformative()
{
var cc = CreateContainer();
Expand All @@ -72,7 +71,6 @@ public void MissingTopLevelExportMessageIsInformative()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)]
public void MissingTopLevelNamedExportMessageIsInformative()
{
var cc = CreateContainer();
Expand All @@ -81,7 +79,6 @@ public void MissingTopLevelNamedExportMessageIsInformative()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)]
public void MissingDependencyMessageIsInformative()
{
var cc = CreateContainer(typeof(UserOfUnregistered));
Expand All @@ -92,7 +89,6 @@ public void MissingDependencyMessageIsInformative()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)]
public void CycleMessageIsInformative()
{
var cc = CreateContainer(typeof(CycleA), typeof(CycleB), typeof(CycleC));
Expand All @@ -106,7 +102,6 @@ public void CycleMessageIsInformative()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)]
public void CardinalityViolationMessageIsInformative()
{
var cc = CreateContainer(typeof(ShouldBeOne), typeof(ButThereIsAnother), typeof(RequiresOnlyOne));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ public InvalidConcreteView(string unsupported) { }
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)]
public void AConcreteTypeWithUnsupportedConstructorsCannotBeUsedAsAMetadataView()
{
var cc = new ContainerConfiguration()
Expand All @@ -102,7 +101,6 @@ public class ImportsWithMetadataInterface
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)]
public void UnsupportedMetadataViewMessageIsInformative()
{
var cc = new ContainerConfiguration().WithParts(typeof(ImportsWithMetadataInterface), typeof(ExportsWithMetadata)).CreateContainer();
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/System.Composition/tests/OpenGenericsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -123,15 +123,13 @@ public void MultipleGenericExportsCanBeSpecifiedAtTheClassLevel()
// In future, the set of allowable generic type mappings will be expanded (see
// ignored tests above).
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)]
public void TypesWithMismatchedGenericParameterListsAreDetectedDuringDiscovery()
{
var x = Assert.Throws<CompositionFailedException>(() => CreateContainer(typeof(RepositoryWithKey<,>)));
Assert.Equal("Exported contract 'IRepository`1' of open generic part 'RepositoryWithKey`2' does not match the generic arguments of the class.", x.Message);
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)]
public void TypesWithNonGenericExportsAreDetectedDuringDiscovery()
{
var x = Assert.Throws<CompositionFailedException>(() => CreateContainer(typeof(RepositoryWithNonGenericExport<>)));
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Composition/tests/SharingTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,6 @@ public class SharingTest : ContainerTests
/// we fail only when we create instance of B.. is that correct.
/// </summary>
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50919", TestPlatforms.Android)]
public void BoundaryExposedBoundaryButNoneImported()
{
try
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ namespace System.IO.Pipelines.Tests
public class FlushAsyncCompletionTests : PipeTest
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50927", TestPlatforms.Android)]
public void AwaitingFlushAsyncAwaitableTwiceCompletesReaderWithException()
{
async Task Await(ValueTask<FlushResult> a)
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.IO.Pipelines/tests/FlushAsyncTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ public async Task CallingFlushAsyncMultipleTimesAllowsFirstToComplete()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50927", TestPlatforms.Android)]
public async Task DoubleFlushAsyncThrows()
{
Pipe.Writer.WriteEmpty(65);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@ public async Task CompleteReaderAfterFlushWithoutAdvancingDoesNotThrow()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50927", TestPlatforms.Android)]
public async Task AdvanceAfterCompleteThrows()
{
await _pipe.Writer.WriteAsync(new byte[1]);
Expand Down Expand Up @@ -621,7 +620,6 @@ public async Task WritingDataMakesDataReadableViaPipeline()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50927", TestPlatforms.Android)]
public async Task DoubleAsyncReadThrows()
{
ValueTask<ReadResult> readTask1 = _pipe.Reader.ReadAsync();
Expand Down Expand Up @@ -658,7 +656,6 @@ public async Task CompleteAfterAdvanceCommits()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50927", TestPlatforms.Android)]
public async Task AdvanceWithoutReadThrows()
{
await _pipe.Writer.WriteAsync(new byte[3]);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ namespace System.IO.Pipelines.Tests
public class ReadAsyncCompletionTests : PipeTest
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50927", TestPlatforms.Android)]
public void AwaitingReadAsyncAwaitableTwiceCompletesWriterWithException()
{
async Task Await(ValueTask<ReadResult> a)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ namespace System.Net.Mail.Tests
public class LoggingTest
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50999", TestPlatforms.Android)]
public void EventSource_ExistsWithCorrectId()
{
Type esType = typeof(SmtpClient).Assembly.GetType("System.Net.NetEventSource", throwOnError: true, ignoreCase: false);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ public void TestConstructorWithStatusCodeArgument()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50999", TestPlatforms.Android)]
public void TestConstructorWithStringArgument()
{
string msg;
Expand Down Expand Up @@ -92,7 +91,6 @@ public void TestConstructorWithStringArgument()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50999", TestPlatforms.Android)]
public void TestConstructorWithStatusCodeAndStringArgument()
{
string msg;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ namespace System.Net.NameResolution.Tests
public class LoggingTest
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50928", TestPlatforms.Android)]
public static void EventSource_ExistsWithCorrectId()
{
Type esType = typeof(Dns).Assembly.GetType("System.Net.NetEventSource", throwOnError: true, ignoreCase: false);
Expand All @@ -30,7 +29,6 @@ public static void EventSource_ExistsWithCorrectId()
}

[ConditionalFact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50928", TestPlatforms.Android)]
public void GetHostEntry_InvalidHost_LogsError()
{
using (var listener = new TestEventListener("Private.InternalDiagnostics.System.Net.NameResolution", EventLevel.Error))
Expand Down Expand Up @@ -65,7 +63,6 @@ public void GetHostEntry_InvalidHost_LogsError()
}

[ConditionalFact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50928", TestPlatforms.Android)]
public async Task GetHostEntryAsync_InvalidHost_LogsError()
{
using (var listener = new TestEventListener("Private.InternalDiagnostics.System.Net.NameResolution", EventLevel.Error))
Expand Down Expand Up @@ -115,7 +112,6 @@ static async Task WaitForErrorEventAsync(ConcurrentQueue<EventWrittenEventArgs>
}

[ConditionalFact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50928", TestPlatforms.Android)]
public void GetHostEntry_ValidName_NoErrors()
{
using (var listener = new TestEventListener("Private.InternalDiagnostics.System.Net.NameResolution", EventLevel.Verbose))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ namespace System.Net.NameResolution.Tests
public class TelemetryTest
{
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50928", TestPlatforms.Android)]
public static void EventSource_ExistsWithCorrectId()
{
Type esType = typeof(Dns).Assembly.GetType("System.Net.NameResolutionTelemetry", throwOnError: true, ignoreCase: false);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3403,7 +3403,6 @@ private void CData_4()

//[Variation(Id = 5, Desc = "WriteCData with ]]>", Priority = 1)]
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50944", TestPlatforms.Android)]
public void WriteCDataWithTwoClosingBrackets_5()
{
XDocument doc = new XDocument();
Expand Down Expand Up @@ -3599,7 +3598,6 @@ private void comment_5()

//[Variation(Id = 6, Desc = "WriteComment with -- in value", Priority = 1)]
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50944", TestPlatforms.Android)]
public void WriteCommentWithDoubleHyphensInValue()
{
XDocument doc = new XDocument();
Expand Down Expand Up @@ -4205,7 +4203,6 @@ private void pi_10()

//[Variation(Id = 11, Desc = "Include PI end tag ?> as part of the text value", Priority = 1)]
[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50944", TestPlatforms.Android)]
public void IncludePIEndTagAsPartOfTextValue()
{
XDocument doc = new XDocument();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ public class ReaderEncodingTests
private static string _invalidCharInThisEncoding = "Invalid character in the given encoding";

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50945", TestPlatforms.Android)]
public static void ReadWithSurrogateCharAndInvalidChar()
{
// {60, 0, 0, 0} is a normal char, {0, 34, 1, 0} is a surrogate char {62, 100, 60, 47} is an invalid char
Expand All @@ -30,7 +29,6 @@ public static void ReadWithSurrogateCharAndInvalidChar()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50945", TestPlatforms.Android)]
public static void ReadWithNormalCharAndInvalidChar()
{
// {60, 0, 0, 0, 65, 0, 0, 0} are normal chars, {62, 100, 60, 47} is an invalid char, similar bytes used below tests
Expand All @@ -43,7 +41,6 @@ public static void ReadWithNormalCharAndInvalidChar()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50945", TestPlatforms.Android)]
public static void ReadWithSurrogateCharAndInvalidChar_ValidXmlStructure()
{
var bytes = new byte[] { 60, 0, 0, 0, 97, 0, 0, 0, 62, 0, 0, 0, 0, 34, 1, 0, 62, 100, 60, 47, 60, 0, 0, 0, 47, 0, 0, 0, 97, 0, 0, 0, 62, 0, 0, 0 };
Expand All @@ -55,7 +52,6 @@ public static void ReadWithSurrogateCharAndInvalidChar_ValidXmlStructure()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50945", TestPlatforms.Android)]
public static void ReadWithSurrogateCharAsElementName()
{
var bytes = new byte[] { 60, 0, 0, 0, 0, 34, 1, 0, 65, 0, 0, 0, 97, 0, 0, 0 };
Expand Down Expand Up @@ -88,7 +84,6 @@ public static void BytesEndingWithSurrogateChar()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50945", TestPlatforms.Android)]
public static void BytesStartingWithInvalidChar()
{
var bytes = new byte[] { 62, 100, 60, 47, 60, 0, 0, 0, 0, 34, 1, 0, 65, 0, 0, 0, 97, 0, 0, 0 };
Expand All @@ -99,7 +94,6 @@ public static void BytesStartingWithInvalidChar()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50945", TestPlatforms.Android)]
public static void BytesEndingWithInvalidChar()
{
var bytes = new byte[] { 60, 0, 0, 0, 97, 0, 0, 0, 62, 0, 0, 0, 65, 0, 0, 0, 65, 0, 0, 0, 97, 0, 0, 0, 62, 100, 60, 47};
Expand All @@ -120,7 +114,6 @@ public static void ReadWithSurrogateChar_ValidXmlStructure()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50945", TestPlatforms.Android)]
public static void ReadWithIncompleteBytes()
{
var bytes = new byte[] { 60, 0, 0, 0, 97, 0, 0, 0, 65, 0, 0, 0, 97, 62, 10};
Expand Down
Loading