-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alter RuntimeComponentManifest.targets to use the correct runtime pack #56431
Conversation
When trying to process what runtime components are available, we were assuming %(ResolvedRuntimePack.PackageDirectory) would give us the correct Microsoft.NETCore.App runtime pack. Unfortunately, the ordering was likely altered when we started setting <KnownRuntimePack> items in the Mono workload. Since relying on position of the items isn't reliable, we will instead use %(ResolvedFrameworkReference) to tell us which runtime pack is active and where it's located. Fixes dotnet#56299
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a check somewhere that @(ResolvedFrameworkReference->WithMetadataValue('Identity', 'Microsoft.NETCore.App')->Count()) == 1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I apply this fix locally, it works.
Wasm workload tests are failing with:
And that seems to be because the json path is:
Note the newlines in the path. fix:
|
src/mono/nuget/Microsoft.NET.Runtime.MonoTargets.Sdk/Sdk/RuntimeComponentManifest.targets
Outdated
Show resolved
Hide resolved
src/mono/nuget/Microsoft.NET.Runtime.MonoTargets.Sdk/Sdk/RuntimeComponentManifest.targets
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/mono/nuget/Microsoft.NET.Runtime.MonoTargets.Sdk/Sdk/RuntimeComponentManifest.targets
Outdated
Show resolved
Hide resolved
wasm Workload tests failing with:
I'll try this out locally. |
…the framework reference
When trying to process what runtime components are available, we were assuming %(ResolvedRuntimePack.PackageDirectory) would give us the correct Microsoft.NETCore.App runtime pack. Unfortunately, the ordering was likely altered when we started setting items in the Mono workload. Since relying on position of the items isn't reliable, we will instead use %(ResolvedFrameworkReference) to tell us which runtime pack is active and where it's located.
Fixes #56299