Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix case of DefaultValue using enum backing type. #55793

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Fix case of DefaultValue using enum backing type. #55793

merged 1 commit into from
Jul 16, 2021

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Jul 16, 2021

Fixes #52116

@ghost
Copy link

ghost commented Jul 16, 2021

Tagging subscribers to this area: @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #52116

Author: ericstj
Assignees: -
Labels:

area-System.ComponentModel
Milestone: -

safern
safern approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stephentoub
stephentoub approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Thanks.

KlausLoeffelmann
KlausLoeffelmann approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too!

@ericstj
Copy link
Member Author

ericstj commented Jul 16, 2021

Staging failure is nuget package download issue during workload install:

Workload installation failed: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. (pkgs.dev.azure.com:443)

@ericstj ericstj merged commit b8c799d into dotnet:main Jul 16, 2021
@DustinCampbell
Copy link
Member

w00t! 🎉

@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@safern safern mentioned this pull request Aug 10, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern approved these changes

@KlausLoeffelmann KlausLoeffelmann KlausLoeffelmann approved these changes

@stephentoub stephentoub stephentoub approved these changes

@DustinCampbell DustinCampbell Awaiting requested review from DustinCampbell

Assignees
No one assigned
Labels
area-System.ComponentModel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ShouldSerializeValue for PropertyDescriptor fails for values of underlying enum types
5 participants
@ericstj @DustinCampbell @stephentoub @KlausLoeffelmann @safern