Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do PGO restore as part of PGO path lookup. #55584

Merged

Conversation

jkoritzinsky
Copy link
Member

Removes one of the MSBuild invocations in the CoreCLR build when using PGO data.

Remove one MSBuild process invocation from our CoreCLR build scripts.
@ghost
Copy link

ghost commented Jul 13, 2021

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Removes one of the MSBuild invocations in the CoreCLR build when using PGO data.

Author: jkoritzinsky
Assignees: -
Labels:

area-Infrastructure-coreclr

Milestone: -

Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks for for now. We should probably pull this out of the native build.

@ghost
Copy link

ghost commented Jul 13, 2021

Hello @jkoritzinsky!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@jkoritzinsky
Copy link
Member Author

Failure is networking issue downloading payloads to run one test suite.

Given everything else is passing, I'm going to merge this in.

@jkoritzinsky jkoritzinsky merged commit b1a8e3e into dotnet:main Jul 13, 2021
@jkoritzinsky jkoritzinsky deleted the simplify-optdata-discovery-coreclr branch July 13, 2021 22:26
@ghost ghost locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants