Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable tests blocking CI #55446

Merged
merged 4 commits into from
Jul 10, 2021
Merged

Disable tests blocking CI #55446

merged 4 commits into from
Jul 10, 2021

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Jul 10, 2021

Disables tests for #55271 and #55435

@hoyosjs hoyosjs requested a review from a team July 10, 2021 03:47
@ghost
Copy link

ghost commented Jul 10, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Disables tests for #55271 and #55435

Author: hoyosjs
Assignees: -
Labels:

area-System.Net
Milestone: -

safern
safern approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc: @wfurt

@ghost
Copy link

ghost commented Jul 10, 2021

Hello @hoyosjs!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@steveisok
Copy link
Member

The mono linux x64 failure looks like a flake.

@hoyosjs
Copy link
Member Author

hoyosjs commented Jul 10, 2021

Yeah, Connect_DualMode_DnsConnect_RetrievedEndPoints_Success was under investigation. I know @antonfirsov changed something in this test recently to try to remove the flakiness.

@hoyosjs hoyosjs merged commit 960e7b3 into main Jul 10, 2021
@hoyosjs hoyosjs deleted the juhoyosa/disable-tests branch July 10, 2021 20:01
@ManickaP
Copy link
Member

ManickaP commented Jul 12, 2021 •
edited
Loading

Related https://github.com/dotnet/core-eng/issues/13675
Some of the tests seem like an infra issue.

@karelz karelz mentioned this pull request Jul 13, 2021
Closed
@karelz karelz added this to the 6.0.0 milestone Jul 15, 2021
@runfoapp runfoapp bot mentioned this pull request Jul 15, 2021
Closed
@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@halter73 halter73 mentioned this pull request Aug 9, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wfurt wfurt wfurt left review comments

@safern safern safern approved these changes

Assignees
No one assigned
Labels
area-System.Net
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@hoyosjs @steveisok @ManickaP @wfurt @safern @karelz