Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Fix property name for Emscripten manifest nuget #55444

Merged
merged 1 commit into from
Jul 10, 2021

Conversation

radical
Copy link
Member

@radical radical commented Jul 10, 2021

.. this allows the version to get updated in eng/Versions.props also,
when updates flow in.

  • And update the version to match Version.Details.xml

.. this allows the version to get updated in `eng/Versions.props` also,
when updates flow in.

- And update the version to match Version.Details.xml
@radical radical added the arch-wasm WebAssembly architecture label Jul 10, 2021
@radical radical requested a review from lewing July 10, 2021 01:14
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Jul 10, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

.. this allows the version to get updated in eng/Versions.props also,
when updates flow in.

  • And update the version to match Version.Details.xml
Author: radical
Assignees: -
Labels:

arch-wasm

Milestone: -

@radical radical merged commit bb39406 into dotnet:main Jul 10, 2021
@radical radical deleted the fix-emscripten-version-prop branch July 10, 2021 10:24
@ghost ghost locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants