Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JsonConstructorAttribute duplicate exception message #55324

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Fix JsonConstructorAttribute duplicate exception message #55324

merged 1 commit into from
Jul 13, 2021

Conversation

Tornhoof
Copy link
Contributor

@Tornhoof Tornhoof commented Jul 8, 2021

Closes #55321

  • Changed text to member instead of property
  • Changed typeof to use TAttribute

@ghost
Copy link

ghost commented Jul 8, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #55321

  • Changed text to member instead of property
  • Changed typeof to use TAttribute
Author: Tornhoof
Assignees: -
Labels:

area-System.Text.Json
Milestone: -

stephentoub
stephentoub approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

eiriktsarpalis
eiriktsarpalis approved these changes Jul 13, 2021
View reviewed changes
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eiriktsarpalis eiriktsarpalis merged commit 0aa781c into dotnet:main Jul 13, 2021
@Tornhoof Tornhoof deleted the FixStjException branch July 13, 2021 13:31
@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@jozkee jozkee Awaiting requested review from jozkee

@layomia layomia Awaiting requested review from layomia

@steveharter steveharter Awaiting requested review from steveharter

Assignees
No one assigned
Labels
area-System.Text.Json
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong Exception Text for duplicate JsonConstructorAttribute
3 participants
@Tornhoof @stephentoub @eiriktsarpalis