Improve MetricEventSource error message #55319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Error event wasn't capturing inner exception info in its message. Switching from Exception.Message to
Exception.ToString() captures more useful messages. We no longer split out the stack separately, but that
wasn't important. The error messages are likely only useful for humans anyway.
A failure showed up in CI and it appears the exception is missing inner exception info that would help track it down. The next time this fails we should get better diagnostics.