Improve MetricEventSource error message #55319
Conversation
The Error event wasn't capturing inner exception info in its message. Switching from Exception.Message to Exception.ToString() captures more useful messages. We no longer split out the stack separately, but that wasn't important. The error messages are likely only useful for humans anyway.
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti Issue DetailsThe Error event wasn't capturing inner exception info in its message. Switching from Exception.Message to A failure showed up in CI and it appears the exception is missing inner exception info that would help track it down. The next time this fails we should get better diagnostics.
|
|
The failures in crypto and com interop appear very unlikely to be related to this change. Given this change is itself trying to help diagnose CI failures we are probably better having it than not. |
ghost
locked as resolved and limited conversation to collaborators
The Error event wasn't capturing inner exception info in its message. Switching from Exception.Message to
Exception.ToString() captures more useful messages. We no longer split out the stack separately, but that
wasn't important. The error messages are likely only useful for humans anyway.
A failure showed up in CI and it appears the exception is missing inner exception info that would help track it down. The next time this fails we should get better diagnostics.