Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dnceng/internal/dotnet-optimization dotnet/arcade dotnet/xharness dotnet/hotreload-utils #55007

Merged
merged 8 commits into from
Jul 2, 2021
Merged

[main] Update dependencies from dnceng/internal/dotnet-optimization dotnet/arcade dotnet/xharness dotnet/hotreload-utils #55007

merged 8 commits into from
Jul 2, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 1, 2021 •
edited
Loading

This pull request updates the following dependencies

From https://dev.azure.com/dnceng/internal/_git/dotnet-optimization

  • Subscription: d3a5b203-1393-4534-5b62-08d8d8feb47e
  • Build: 20210630.5
  • Date Produced: 6/30/2021 3:06 PM
  • Commit: 366fc54b3a9b6226dbbbf3672fae78ba82e82b6f
  • Branch: refs/heads/main

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20210630.2
  • Date Produced: 6/30/2021 4:06 PM
  • Commit: 26345756f99087811b1fe4d02ff213eb172ec506
  • Branch: refs/heads/main

From https://github.com/dotnet/xharness

  • Subscription: be30ac4f-4b72-4287-1eb6-08d8d8fef0ea
  • Build: 20210630.2
  • Date Produced: 6/30/2021 6:22 PM
  • Commit: 6d17e5b
  • Branch: refs/heads/main

From https://github.com/dotnet/hotreload-utils

  • Subscription: a712faa5-42ec-4225-f239-08d913ef4ff4
  • Build: 20210630.1
  • Date Produced: 6/30/2021 12:51 PM
  • Commit: a8e0dc88077495e43d7820f631815fa95ce92f8a
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://dev.azure.com/dnceng/internal/_git/d…
2460c93 
…otnet-optimization build 20210630.5

optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.21329.4 -> To Version 1.0.0-prerelease.21330.5
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20210…
be196c9 
…630.2

Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
 From Version 6.0.0-beta.21329.8 -> To Version 6.0.0-beta.21330.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/xharness build 202…
fec3a69 
…10630.2

Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Xunit
 From Version 1.0.0-prerelease.21328.4 -> To Version 1.0.0-prerelease.21330.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/hotreload-utils bu…
b64e95a 
…ild 20210630.1

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 1.0.1-alpha.0.21328.1 -> To Version 1.0.1-alpha.0.21330.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dnceng/internal/dotnet-optimization [main] Update dependencies from dnceng/internal/dotnet-optimization dotnet/arcade dotnet/xharness dotnet/hotreload-utils Jul 1, 2021
@lewing
Copy link
Member

lewing commented Jul 1, 2021

resolved the version conflicts

@lewing
Copy link
Member

lewing commented Jul 1, 2021

@lambdageek lots of hot reload test failures here

@lambdageek
Copy link
Member

@lambdageek lots of hot reload test failures here

Thanks, I'm looking at it. If I don't fix it up by EOD, we should disable the test here for all of mono:

runtime/src/libraries/System.Runtime.Loader/tests/ApplyUpdateTest.cs

Lines 19 to 21 in be80f67

[ConditionalFact(typeof(ApplyUpdateUtil), nameof (ApplyUpdateUtil.IsSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/54617", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsMonoAOT))]
void StaticMethodBodyUpdate()

@lambdageek
Copy link
Member

Looks like recent changes in Roslyn have caused it to start emitting new nullability attributes even if they have the same exact value. Mono isn't ready to pick up additional custom attributes. I asked the Roslyn folks for advice.

But also I will turn off nullability on this particular EnC test.

@lewing
Copy link
Member

lewing commented Jul 1, 2021 •
edited
Loading 

 Discovering: System.IO.Hashing.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.IO.Hashing.Tests (found 145 of 153 test cases)
  Starting:    System.IO.Hashing.Tests (parallel test collections = on, max threads = 4)
    System.IO.Hashing.Tests.XxHash64Tests.StaticVerifyOneShotArray(testCase: Nobody inspects the spammish repetition) [FAIL]
      System.Security.VerificationException : Method System.MemoryExtensions.SequenceEqual: type argument 'System.Byte' violates the constraint of type parameter 'T'.
      Stack Trace:
           at System.IO.Hashing.Tests.NonCryptoHashTestDriver.TestCase.VerifyResponse(ReadOnlySpan`1 response)
        /_/src/libraries/System.IO.Hashing/tests/NonCryptoHashTestDriver.cs(167,0): at System.IO.Hashing.Tests.NonCryptoHashTestDriver.StaticVerifyOneShotArrayDriver(TestCase testCase)
        /_/src/libraries/System.IO.Hashing/tests/XxHash64Tests.cs(160,0): at System.IO.Hashing.Tests.XxHash64Tests.StaticVerifyOneShotArray(TestCase testCase)
    System.IO.Hashing.Tests.Crc32Tests.StaticVerifyOneShotSpanToArray(testCase: Empty) [FAIL]
      System.Security.VerificationException : Method System.MemoryExtensions.SequenceEqual: type argument 'System.Byte' violates the constraint of type parameter 'T'.
      Stack Trace:
           at System.IO.Hashing.Tests.NonCryptoHashTestDriver.TestCase.VerifyResponse(ReadOnlySpan`1 response)
        /_/src/libraries/System.IO.Hashing/tests/NonCryptoHashTestDriver.cs(173,0): at System.IO.Hashing.Tests.NonCryptoHashTestDriver.StaticVerifyOneShotSpanToArrayDriver(TestCase testCase)
        /_/src/libraries/System.IO.Hashing/tests/Crc32Tests.cs(129,0): at System.IO.Hashing.Tests.Crc32Tests.StaticVerifyOneShotSpanToArray(TestCase testCase)
    System.IO.Hashing.Tests.XxHash32Tests_Seeded_007.StaticVerifyOneShotSpanToSpan(testCase: Nobody inspects the spammish repetition) [FAIL]
      System.Security.VerificationException : Method System.MemoryExtensions.SequenceEqual: type argument 'System.Byte' violates the constraint of type parameter 'T'.

Looks like new analysis errors now

@lewing lewing merged commit 97898a4 into main Jul 2, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-main-e5915727-a1ae-4f03-bc39-d876c9e85df1 branch July 2, 2021 05:38
thaystg added a commit to thaystg/runtime that referenced this pull request Jul 2, 2021
@thaystg
Merge remote-tracking branch 'origin/main' into thays_hot_reload_debug
946c391 
* origin/main: (27 commits)
  [mono][llvm] Only emit 'LLVM failed' messages on verbosity > 0. (dotnet#55060)
  Http2Stream throws a wrapped Http2ConnectionException on GO_AWAY (dotnet#54625)
  [main] Update dependencies from dnceng/internal/dotnet-optimization dotnet/arcade dotnet/xharness dotnet/hotreload-utils (dotnet#55007)
  disable a failing test. (dotnet#55063)
  [mono][wasm] Disable some tests which crash on AOT. (dotnet#55054)
  Fix fix_allocation_context for regions (dotnet#54931)
  Delete stale references to System.IO.FileSystem.Primitives (dotnet#55041)
  Add binplaced analyzers to ASP.NET transport package (dotnet#55042)
  [mono] Enable many HardwareIntrinsic tests on wasm
  Delete `compQuirkForPPP`. (dotnet#55050)
  [Mono] Condition Workload AOT import to be osx only (dotnet#55040)
  package native quic library (dotnet#54992)
  Make GlobalizationMode code consistent (dotnet#55039)
  Expand PerfMap format to support metadata for symbol indexation (dotnet#53792)
  [debugger]Componentize debugger (dotnet#54887)
  [Mono] Include loaded interpreter methods as EventPipe session rundown method events. (dotnet#54953)
  Delete stale ActiveIssue from HttpHeadersTest (dotnet#55027)
  Poison address-exposed user variables in debug (dotnet#54685)
  Recategorize emsdk dependency (dotnet#55028)
  Remove the the wasm AOT specific test project exclusions (dotnet#54988)
  ...
@danmoseley danmoseley added the area-codeflow for labeling automated codeflow label Jul 28, 2021
@karelz karelz mentioned this pull request Jul 28, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lewing @lambdageek @danmoseley