Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nullable annotations to System.ComponentModel.TypeConverter #54961

Merged
merged 4 commits into from
Jul 8, 2021
Merged

Add nullable annotations to System.ComponentModel.TypeConverter #54961

merged 4 commits into from
Jul 8, 2021

Conversation

krwq
Copy link
Member

@krwq krwq commented Jun 30, 2021

cc: @dotnet/nullablefc

@krwq krwq requested a review from stephentoub June 30, 2021 14:12
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jun 30, 2021

Tagging subscribers to this area: @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

cc: @dotnet/nullablefc

Author: krwq
Assignees: -
Labels:

area-System.ComponentModel, new-api-needs-documentation
Milestone: -

@krwq krwq mentioned this pull request Jun 30, 2021
Open
23 tasks
@ericstj ericstj requested a review from safern June 30, 2021 16:21
@krwq krwq force-pushed the nullable-type-converter branch from 0eca142 to 0c041e7 Compare July 1, 2021 09:43
@krwq
Copy link
Member Author

krwq commented Jul 1, 2021

I've rebased to fix the merge conflicts - note they didn't affect TypeConverter (except comment changes) - just System.Data.Common

@stephentoub
Copy link
Member

This is daunting ;-)
image

stephentoub
stephentoub approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only spot checked, but overall it LGTM (left a few comments about the TODO-NULLABLEs throughout).

This was referenced Jul 5, 2021
Open
Open
Closed
@dotnet dotnet deleted a comment from azure-pipelines bot Jul 7, 2021
@dotnet dotnet deleted a comment from azure-pipelines bot Jul 7, 2021
@krwq krwq closed this Jul 7, 2021
@krwq krwq reopened this Jul 7, 2021
@krwq krwq merged commit 885296a into dotnet:main Jul 8, 2021
@ManickaP ManickaP mentioned this pull request Jul 20, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern left review comments

@roji roji roji left review comments

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.ComponentModel new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krwq @stephentoub @roji @safern