Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spill single-def variable at definition to avoid further spilling #54345

Merged
merged 20 commits into from
Jul 10, 2021
Merged

Spill single-def variable at definition to avoid further spilling #54345

merged 20 commits into from
Jul 10, 2021

Commits on Jul 9, 2021

  1. Print single-def

    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    d5dc108 View commit details
    Browse the repository at this point in the history

  2. Rename lvEhWriteThruCandidate->lvSingleDefRegCandidate, introduce isS… 

    …ingleDef
    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    5176e85 View commit details
    Browse the repository at this point in the history

  3. Introduce singleDefSpillAfter 

    If a single-def variable is decided to get spilled in its lifetime, then
spill it at the firstRefPosition RefTypeDef so the value of the variable
is always valid on the stack. Going forward, no more spills will be needed
for such variable or no more resolutions (reg to stack) will be needed for
such single-def variables.
    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    3262f3f View commit details
    Browse the repository at this point in the history

  4. jit format

    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    bed12a0 View commit details
    Browse the repository at this point in the history

  5. some fixes

    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    62b1d57 View commit details
    Browse the repository at this point in the history

  6. wip

    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    4563709 View commit details
    Browse the repository at this point in the history

  7. Add check of isSingleDef in validateInterval()

    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    4707548 View commit details
    Browse the repository at this point in the history

  8. Make isSingleDef during buildIntervals

    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    2d67df2 View commit details
    Browse the repository at this point in the history

  9. minor fix in lclvars.cpp

    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    12ef329 View commit details
    Browse the repository at this point in the history

  10. some fixes after self CR

    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    a5dbc39 View commit details
    Browse the repository at this point in the history

  11. Updated some comments

    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    803e59e View commit details
    Browse the repository at this point in the history

  12. Remove lvSpillAtSingleDef from some asserts

    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    1171e15 View commit details
    Browse the repository at this point in the history

  13. Use singleDefSpill information in getWeight()

    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    d792cfc View commit details
    Browse the repository at this point in the history

  14. Remove lvSpillAtSingleDef from some more checks

    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    25770df View commit details
    Browse the repository at this point in the history

  15. Mark lvSpillAtSingleDef whenever refPosition->singleDefSpill==true

    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    4d3b6b6 View commit details
    Browse the repository at this point in the history

  16. Add TODO for SingleDefVarCandidate

    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    22a1a7d View commit details
    Browse the repository at this point in the history

  17. Some notes on setting singleDefSpill

    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    e3383c1 View commit details
    Browse the repository at this point in the history

  18. jit format

    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    8facc97 View commit details
    Browse the repository at this point in the history

  19. review feedback

    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    d3e03a6 View commit details
    Browse the repository at this point in the history

  20. review comments

    @kunalspathak
    kunalspathak committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    649c6c4 View commit details
    Browse the repository at this point in the history